Bug 3410

The current SDK is broken when doing "make install.sdk", failing when getting
to the first module (bitmap), with the following error:

installing driver SDK in lib/font/bitmap/module...
make[5]: Entering directory
`/home/mharris/rpmbuild/BUILD/xorg-x11-6.8.99.8/xc/lib/font/bitmap/module'
make[5]: *** No rule to make target `libbitmap.so', needed by `install.sdk'.  Stop.
make[5]: Leaving directory
`/home/mharris/rpmbuild/BUILD/xorg-x11-6.8.99.8/xc/lib/font/bitmap/module'
make[4]: *** [install.sdk] Error 2
make[4]: Leaving directory
`/home/mharris/rpmbuild/BUILD/xorg-x11-6.8.99.8/xc/lib/font/bitmap'
make[3]: *** [install.sdk] Error 2
make[3]: Leaving directory
`/home/mharris/rpmbuild/BUILD/xorg-x11-6.8.99.8/xc/lib/font'
make[2]: *** [install.sdk] Error 2
make[2]: Leaving directory `/home/mharris/rpmbuild/BUILD/xorg-x11-6.8.99.8/xc/lib'
make[1]: *** [install.sdk] Error 2
make[1]: Leaving directory `/home/mharris/rpmbuild/BUILD/xorg-x11-6.8.99.8/xc'
make: *** [install.sdk] Error 2
make: Leaving directory `/home/mharris/rpmbuild/BUILD/xorg-x11-6.8.99.8/xc'
error: Bad exit status from /home/mharris/rpmbuild/tmp/rpm-tmp.50886 (%install)


Investigation shows that the bitmap module is still being built as a
static lib even when MakeDllModules is enabled as it is by default in
CVS head.  Further investigation shows that the type1 module also gets
built as a static lib, however the "freetype" module gets built properly
as a .so.

The xc/lib/font/FreeType/module/Imakefile contains quite different code
which conditionalizes how the freetype module gets built depending on
wether it is a MakeDllModules build or not.  The Imakefiles for the
bitmap and type1 modules do not handle this situation properly however.

I considered attempting a patch to make the bitmap and type1 Imakefiles
more similar to the freetype one, however while the freetype one *works*,
it seems horribly written and very wrong.

ie:
/*#define BuildFreetypeDlModule NO*/

#if !defined(BuildFreetypeDlModule)
# define BuildFreetypeDlModule (HasFreetype2 && HasDlopen)
#endif

#if !BuildFreetypeDlModule
EXTRADEFINES = Freetype2BuildDefines -DFONTMODULE
# else
# undef MakeDllModules
# define MakeDllModules YES
#endif


This code seems backwards.  Shouldn't this be preferred instead?

#if !MakeDllModules
EXTRADEFINES = Freetype2BuildDefines -DFONTMODULE
# else
#define BuildFreetypeDlModule YES
#endif



Rather than going down that road however, it seems to me that this should
be code that is factored out into Imake rules files rather than being
duplicated throughout every X server module's Imakefile throughout the
tree.  That would remove a huge mess of conditional stuff from every
module Imakefile.

Admittedly, I haven't checked to see if there are already rules for this
that are just not being used in these modules currently, but I wanted
to report this issue before heading to bed, to gather thoughts
from others.