Summary: | Nouveau 3D driver: nv50_pc_emit.c:863 assertion error kills Compiz | ||
---|---|---|---|
Product: | Mesa | Reporter: | Sense Hofstede <sense> |
Component: | Drivers/DRI/nouveau | Assignee: | Nouveau Project <nouveau> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | CC: | henrik, om26er |
Version: | 7.10 | ||
Hardware: | Other | ||
OS: | All | ||
See Also: | https://launchpad.net/bugs/710588 | ||
Whiteboard: | |||
i915 platform: | i915 features: |
Description
Sense Hofstede
2011-02-11 07:06:23 UTC
Also to add this is used to work with mesa 7.9 the update to 7.10 broke things. This is fixed by the nv50 part of the commit: commit 7401590dedf6f2abb1f0f0db988be90acb1fb84f Author: Christoph Bumiller <e0425955@student.tuwien.ac.at> Date: Mon Feb 7 14:54:17 2011 +0100 nv50,nvc0: do not forget to apply sign mode to saved TGSI inputs diff --git a/src/gallium/drivers/nv50/nv50_tgsi_to_nc.c b/src/gallium/drivers/nv50/nv50_tgsi_to_nc.c index d6b80c3..ce9300a 100644 --- a/src/gallium/drivers/nv50/nv50_tgsi_to_nc.c +++ b/src/gallium/drivers/nv50/nv50_tgsi_to_nc.c @@ -1130,7 +1130,7 @@ emit_fetch(struct bld_context *bld, const struct tgsi_full_instruction *insn, case TGSI_FILE_INPUT: res = bld_saved_input(bld, idx, swz); if (res && (insn->Instruction.Opcode != TGSI_OPCODE_TXP)) - return res; + break; res = new_value(bld->pc, bld->ti->input_file, type); res->reg.id = bld->ti->input_map[idx][swz]; I've done a piglit run on my NV98 system against the 7.10 branch; this shows no difference with or without the cherry-pick. So this doesn't regress anything obvious, but there's also clearly a piglit test to be written :). |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.