| Summary: | [llvmpipe] piglit framebuffer-srgb regression | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Vinson Lee <vlee> |
| Component: | Other | Assignee: | Brian Paul <brianp> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | airlied, jfonseca |
| Version: | git | ||
| Hardware: | x86 (IA32) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
framebuffer-srgb.png
we don't support sRGB rendering, say so in is_format_supported() |
||
21b0996dfcbe62c55dd31cc316cd47f2b8531d2e is the first bad commit commit 21b0996dfcbe62c55dd31cc316cd47f2b8531d2e Author: Dave Airlie <airlied@redhat.com> Date: Sun Feb 6 19:01:58 2011 +1000 mesa/st: enable GL_EXT_framebuffer_sRGB If the formats don't match we need to update the surface with the new format. if we can render to SRGB formats, enable the extension Signed-off-by: Dave Airlie <airlied@redhat.com> :040000 040000 1ebe33d2fe0e104a8e261d6a97e5034725c14809 dba1f242c4edbe8f410ca1d4ea3f728a829a7e35 M src bisect run success This is most likely a llvmpipe bug: it advertises SRGB support but never implemented it. mesa: 1a867385d56022e904ef0235cbed545057fcb998 (master) This regression is still present. Created attachment 52052 [details] [review] we don't support sRGB rendering, say so in is_format_supported() We never implemented sRGB rendering in llvmpipe. The attached patch adds a check in is_format_supported() to return false if we're asked if we can do it. The llvmpipe driver doesn't support rendering to sRGB surfaces but that's not what we were telling the state tracker. Fixed with commit 6b3e75de7c2dd6be6bf1acd0e996bdb1def702a1. mesa: b875838ec302c4e830e13ebd5fa834fd22830279 (master) Verified fixed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 43280 [details] framebuffer-srgb.png mesa: df54b53b7d12a3bca5867b6649cb308feb36f0da (master) piglit framebuffer-srgb has regressed. It still passes on swrast and softpipe. $ ./bin/framebuffer-srgb Probe at (30,30) Expected: 0.000000 0.583837 0.000000 Observed: 0.000000 0.298039 0.000000 Probe at (20,0) Expected: 0.000000 0.797741 0.000000 Observed: 0.000000 0.596078 0.000000