Bug 34219

Summary:	Gentoo QA warning: x11-apps/xkbcomp-1.2.0: geometry.c:2578: warning: the address of ‘ol’ will always evaluate as ‘true’
Product:	xorg	Reporter:	Dan Wallis <mrdanwallis>
Component:	App/xkbcomp	Assignee:	Xorg Project Team <xorg-team>
Status:	RESOLVED FIXED	QA Contact:	Xorg Project Team <xorg-team>
Severity:	minor
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Dan Wallis 2011-02-12 19:32:56 UTC

When installing x11-apps/xkbcomp-1.2.0 on my Gentoo system, I received the following notice:

 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * geometry.c:2578: warning: the address of ‘ol’ will always evaluate as ‘true’

 * Please do not file a Gentoo bug and instead report the above QA
 * issues directly to the upstream developers of this software.
 * Homepage: http://xorg.freedesktop.org/
 * ERROR: x11-apps/xkbcomp-1.2.0 failed:
 *   install aborted due to poor programming practices shown above


This appears to be the relevant portion from the build log itself:

  CC     geometry.o
i686-pc-linux-gnu-gcc -std=gnu99 -DHAVE_CONFIG_H -I.     -DDFLT_XKB_CONFIG_ROOT='"/usr/share/X11/xkb"' -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -fno
-strict-aliasing -Wbad-function-cast -Wformat=2 -Wold-style-definition -Wdeclaration-after-statement  -O2 -march=i686 -pipe -c geometry.c
geometry.c: In function ‘HandleOverlayDef’:
geometry.c:2578: warning: the address of ‘ol’ will always evaluate as ‘true’
  CC     indicators.o


But I don't know how to fix this. Happy to provide more information as required.

Comment 1 Julien Cristau 2011-02-13 04:13:11 UTC

http://patchwork.freedesktop.org/patch/4080/

Comment 2 Julien Cristau 2011-02-13 12:23:38 UTC

Fixed in master, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.