Bug 34285

Summary:	RV620 : r600g : S3TC: rendering of textures with strides with last Dave commit
Product:	Mesa	Reporter:	Alexandre Derumier <aderumier>
Component:	Drivers/Gallium/r600	Assignee:	Default DRI bug account <dri-devel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	git
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Nexuiz with s3tc torcs with s3tc tremulous with s3tc Heroes of Newerth with S3TC

Description Alexandre Derumier 2011-02-14 22:53:48 UTC

since commit 8e0437914bb786d0b05be8f95e4ff37bf5a19f44, r600g: add support for s3tc formats.

before patch, textures was black with s3tc enable.

now, it's much better, but i have strides/lines in textures in all games.

games tested (R600_ENABLE_S3TC=1):

doom3
nexuiz
tremulous
torcs
heroes of newerth
warsow


I'll post some screenshots, I hope it can help :)

Comment 1 Alexandre Derumier 2011-02-14 22:54:41 UTC

Created attachment 43363 [details]
Nexuiz with s3tc

Comment 2 Alexandre Derumier 2011-02-14 22:55:19 UTC

Created attachment 43364 [details]
torcs with s3tc

Comment 3 Alexandre Derumier 2011-02-14 22:58:11 UTC

Created attachment 43365 [details]
tremulous with s3tc

Comment 4 Alexandre Derumier 2011-02-14 22:59:00 UTC

I forget to say:

I don't have any errors in dmesg like before.

Comment 5 Alexandre Derumier 2011-02-14 23:21:40 UTC

Created attachment 43366 [details]
Heroes of Newerth with S3TC

Comment 6 Dave Airlie 2011-02-15 01:04:45 UTC

should be fixed in part, but you should still be getting kernel errors with s3tc textures on r600/r700 until I finish the kernel side of things.

Comment 7 Tobias Jakobi 2011-02-15 01:31:31 UTC

Confirming fixed on my RV740.

Comment 8 Alexandre Derumier 2011-02-15 22:22:09 UTC

not yet fixed on my RV620.

today it's worst than yesterday.

some games are hanging (nexuiz,heroes of newerth) and I have a tons of texture errors in dmesg (nothing yesterday).


radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 49
[drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 51
[drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 51
[drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
radeon 0000:01:00.0: r600_check_texture_resource:1208 texture invalid format 51
[drm:radeon_cs_ioctl] *ERROR* Invalid command stream !

Comment 9 Dave Airlie 2011-02-16 00:07:07 UTC

as I said you'll get kernel errors until the kernel side is done, there are two patches in

http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=shortlog;h=refs/heads/drm-radeon-testing

that needs testing, but I've found r600 has a problem with some colors in the compressed textures,

Comment 10 Alexandre Derumier 2011-02-16 00:35:47 UTC

Ok, so i'll send a comment when it'll be working.

And a very big thank you Dave for all your hard work !

Comment 11 Alexandre Derumier 2011-02-16 22:45:04 UTC

seem to be ok for me RV620 today, since 231bf886dae9c7df0ae3e16acee904024a08824f commit.

i had tested all my games, they are all working perfectly !

Thanks Again Dave, you are doing a wonderful work!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.