Bug 34384

Summary:	[PATCH] In CairoOutputDev.cc: cairo_pattern_mesh_* renamed to cairo_mesh_pattern_*
Product:	poppler	Reporter:	Florian Gawrilowicz <flo.gravo>
Component:	cairo backend	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Proposed patch Patch to require Cairo 1.11.3 in configure

Description Florian Gawrilowicz 2011-02-17 04:56:04 UTC

Compile against latest cairo git-version gives this error:
CairoOutputDev.cc: In member function 'virtual GBool CairoOutputDev::gouraudTriangleShadedFill(GfxState*, GfxGouraudTriangleShading*)':
CairoOutputDev.cc:836:49: error: 'cairo_pattern_mesh_begin_patch' was not declared in this scope
CairoOutputDev.cc:838:53: error: 'cairo_pattern_mesh_move_to' was not declared in this scope
CairoOutputDev.cc:839:53: error: 'cairo_pattern_mesh_line_to' was not declared in this scope
CairoOutputDev.cc:847:23: error: 'cairo_pattern_mesh_set_corner_color_rgb' was not declared in this scope
CairoOutputDev.cc:850:47: error: 'cairo_pattern_mesh_end_patch' was not declared in this scope
CairoOutputDev.cc: In member function 'virtual GBool CairoOutputDev::patchMeshShadedFill(GfxState*, GfxPatchMeshShading*)':
CairoOutputDev.cc:879:49: error: 'cairo_pattern_mesh_begin_patch' was not declared in this scope
CairoOutputDev.cc:881:77: error: 'cairo_pattern_mesh_move_to' was not declared in this scope
CairoOutputDev.cc:885:38: error: 'cairo_pattern_mesh_curve_to' was not declared in this scope
CairoOutputDev.cc:902:90: error: 'cairo_pattern_mesh_set_control_point' was not declared in this scope
CairoOutputDev.cc:938:28: error: 'cairo_pattern_mesh_set_corner_color_rgb' was not declared in this scope
CairoOutputDev.cc:940:47: error: 'cairo_pattern_mesh_end_patch' was not declared in this scope
make[3]: *** [CairoOutputDev.lo] Error 1


See:
http://comments.gmane.org/gmane.comp.lib.cairo/21217
http://cgit.freedesktop.org/cairo/commit/?id=5f039f0f894082c383884595220f6f0368ab72cf

Comment 1 Florian Gawrilowicz 2011-02-17 05:07:41 UTC

Created attachment 43483 [details] [review]
Proposed patch

This just remanes the funtions in CairoOutputDev.cc. If backwards compatibility is wanted some #defines would be needed.

Comment 2 Florian Gawrilowicz 2011-02-17 05:09:14 UTC

Created attachment 43484 [details] [review]
Patch to require Cairo 1.11.3 in configure

Just sets CAIRO_VERSION to 1.11.3

Comment 3 Carlos Garcia Campos 2011-02-26 04:11:35 UTC

Thanks for the patch, I prefer to wait until 1.11.4 is released, though.

Comment 4 Carlos Garcia Campos 2012-03-25 06:56:57 UTC

This is fixed in git master now that cairo 1.12 is released.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.