Summary: | [i945gm] Screen Corruption with new Xorg stack with terminal programs (bisected) | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | xorg | Reporter: | Bryce Harrington <bryce> | ||||||||||||||||||
Component: | Driver/intel | Assignee: | Chris Wilson <chris> | ||||||||||||||||||
Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||||||||||||||||
Severity: | critical | ||||||||||||||||||||
Priority: | high | CC: | bugzilla.i.sekler, freedesktop-bugzilla, lukian+freedesktop, simon.strandman | ||||||||||||||||||
Version: | 7.6 (2010.12) | Keywords: | regression | ||||||||||||||||||
Hardware: | x86-64 (AMD64) | ||||||||||||||||||||
OS: | Linux (All) | ||||||||||||||||||||
Whiteboard: | |||||||||||||||||||||
i915 platform: | i915 features: | ||||||||||||||||||||
Attachments: |
|
Description
Bryce Harrington
2011-02-22 16:05:04 UTC
Created attachment 43684 [details]
BootDmesg.txt
Created attachment 43685 [details]
CurrentDmesg.txt
Created attachment 43686 [details]
XorgLog.txt
Created attachment 43687 [details]
Still-Present.png
Screenshot.
Notice the lines of pixels through certain text elements. These appear sometimes when scrolling rapidly.
(Fwiw, we've gotten some other bug reports relating to terminal corruption regressions, which may or may not be related, but I'm keeping them separate for now.) *** Bug 34714 has been marked as a duplicate of this bug. *** I reported #34714 but I'm pretty sure this is the same issue. It's not a 64bit issue btw, I have it on my 32bit netbook. I'm optimistic that commit 467cffba85791cdfce38c124d75bd578f4bb8625 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Mon Mar 7 10:42:03 2011 +0000 drm/i915: Rebind the buffer if its alignment constraints changes with tiling Early gen3 and gen2 chipset do not have the relaxed per-surface tiling constraints of the later chipsets, so we need to check that the GTT alignment is correct for the new tiling. If it is not, we need to rebind. Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> will have had some positive impact on a few of these corruptions... (In reply to comment #8) > I'm optimistic that > commit 467cffba85791cdfce38c124d75bd578f4bb8625 > will have had some positive impact on a few of these corruptions... Hard to say if it has, I still see lots of corruption. I tested with the Ubuntu 2.6.38-6.34 kernel + 467cffba85791cdfce38c124d75bd578f4bb8625. Can confirm that this corruption is still present in the Ubuntu-2.6.38-7.35 kernel which is v2.6.38 based and contains Chris' fix. In the Ubuntu bug it has been suggested that reverting commit 6bda10d152735c22baf1dcd92937420b4b0a359a helps with this corruption. I can confirm that reverting that does indeed eliminate the corruption in terminal windows for me, _however_ I then get corruption elsewhere mostly in icons for flies on the desktop and on chromiums toolbar icons as they change colour; mostly a striated look, as if incorrectly tiled. Created attachment 44535 [details] [review] Reorder the pipelined flush Had a chat with Andy Whitcroft and we put together this patch for testing, there will be a Ubuntu kernel availably shortly. (In reply to comment #12) > Created an attachment (id=44535) [details] > Reorder the pipelined flush > > Had a chat with Andy Whitcroft and we put together this patch for testing, > there will be a Ubuntu kernel availably shortly. Makes a massive difference. I haven't seen any corruption with this patch. Created attachment 44552 [details] [review] Fix piplelined fence corruption A second variant I want to try. Hopefully this introduces far fewer stalls than the first. Created attachment 44553 [details] [review] Fix piplelined fence corruption Created attachment 44574 [details] [review] Fix tiling corruption New version for linus/master Working on the theory that it is one and the same bug: commit b5b5ac2dec49ea5ae033434efa90863aa5cdfb2c Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Thu Mar 17 15:23:22 2011 +0000 drm/i915: Fix tiling corruption from pipelined fencing ... even though it was disabled. A mistake in the handling of fence reuse caused us to skip the vital delay of waiting for the object to finish rendering before changing the register. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=34584 Cc: Andy Whitcroft <apw@canonical.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> [Note for 2.6.38-stable, we need to reintroduce the interruptible passing] Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Tested-by: Dave Airlie <airlied@linux.ie> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.