Bug 34812

Summary:	IRC command PART is improperly constructed
Product:	Telepathy	Reporter:	Chandni Verma <chandniverma2112>
Component:	idle	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://gitorious.org/glassrose-gnome/telepathy-idle/commits/fix-missing-colon-in-PART-command-construction
Whiteboard:
i915 platform:		i915 features:

Description Chandni Verma 2011-02-27 20:59:51 UTC

This is part of idle log obtained on entering "/part #cv iiii jjjj kkkk llll" on empathy:

** (telepathy-idle:32209): DEBUG: iface_send_impl: sent "PART #cv iiii jjjj llll kkkkk
" to IOChannel 0x81c1750
** (telepathy-idle:32209): DEBUG: _parse_message: parsing ":glassrose_!~glassrose@122.177.113.215 PART #cv :"iiii""
** (telepathy-idle:32209): DEBUG: _parse_and_forward_one: message code 9


Seems idle is mis parsing the optional message in PART command.

Comment 1 Chandni Verma 2011-02-27 21:22:58 UTC

This branch prepends a colon to the optional message portion of the IRC PART command.
Ref: Section 2.3.1 and 3.2.2 of IRC RFC: http://www.irchelp.org/irchelp/rfc/rfc2812.txt

Comment 2 Chandni Verma 2011-02-27 21:51:29 UTC

Corrected branch: http://gitorious.org/glassrose-gnome/telepathy-idle/commits/fix-missing-colon-in-PART-command-construction

In this branch, construction of PART command sent over IO channel is corrected.

Comment 3 Will Thompson 2011-02-28 05:21:27 UTC

This patch looks good! I shall commit it (just as soon as I've fixed up my git checkouts to point to freedesktop.org).

Comment 4 Will Thompson 2011-02-28 08:38:27 UTC

Committed: <http://cgit.freedesktop.org/telepathy/telepathy-idle/commit/?id=248444a>. I also added a test case, and fixed a similar bug when kicking people.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.