Bug 34907

This is needed by gnome-shell btw: https://bugzilla.gnome.org/show_bug.cgi?id=642793

http://git.collabora.co.uk/?p=user/cassidy/telepathy-glib;a=shortlog;h=refs/heads/messages-types-34907

12:01              wjt | cassidy: comments like +      /* Copy the array */
12:01              wjt | cassidy: don't add anything
12:01              wjt | cassidy: +      DEBUG ("Channel doesn't have 
                         Messages.MessageTypes in its "
12:01              wjt | +          "immutable properties");
12:01              wjt | cassidy: include the channel's path

Also I imagine API like gboolean tp_text_channel_supports_message_type (TpTextChannel *, TpChannelTextMessageType) might be useful in C, where it's a PITA to check whether a GArray contains an element. Not a merge blocker.

(In reply to comment #3)
> 12:01              wjt | cassidy: comments like +      /* Copy the array */
> 12:01              wjt | cassidy: don't add anything

Why on earth did I write that? I hate this kind of comments as well. Removed (squashed).

> 12:01              wjt | cassidy: +      DEBUG ("Channel doesn't have 
>                          Messages.MessageTypes in its "
> 12:01              wjt | +          "immutable properties");
> 12:01              wjt | cassidy: include the channel's path

Done.

> Also I imagine API like gboolean tp_text_channel_supports_message_type
> (TpTextChannel *, TpChannelTextMessageType) might be useful in C, where it's a
> PITA to check whether a GArray contains an element. Not a merge blocker.

All cool kids use javascript these days. :p
But yeah, that's a good idea, I've added it.

(In reply to comment #4)
> (In reply to comment #3)
> > 12:01              wjt | cassidy: comments like +      /* Copy the array */
> > 12:01              wjt | cassidy: don't add anything
> 
> Why on earth did I write that? I hate this kind of comments as well. Removed
> (squashed).

But you didn't remove the thing right below it…

+      /* Create an empty array */
+      self->priv->message_types = g_array_new (FALSE, FALSE,
+          sizeof (TpChannelTextMessageType));

> > 12:01              wjt | cassidy: +      DEBUG ("Channel doesn't have 
> >                          Messages.MessageTypes in its "
> > 12:01              wjt | +          "immutable properties");
> > 12:01              wjt | cassidy: include the channel's path
> 
> Done.

Awesome.
> 
> > Also I imagine API like gboolean tp_text_channel_supports_message_type
> > (TpTextChannel *, TpChannelTextMessageType) might be useful in C, where it's a
> > PITA to check whether a GArray contains an element. Not a merge blocker.
> 
> All cool kids use javascript these days. :p
> But yeah, that's a good idea, I've added it.

+ * Check if message of type @type can be send on this channel.

                                          ^^^^ should be ‘sent’

ditto the next line.

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > 12:01              wjt | cassidy: comments like +      /* Copy the array */
> > > 12:01              wjt | cassidy: don't add anything
> > 
> > Why on earth did I write that? I hate this kind of comments as well. Removed
> > (squashed).
> 
> But you didn't remove the thing right below it…
> 
> +      /* Create an empty array */
> +      self->priv->message_types = g_array_new (FALSE, FALSE,
> +          sizeof (TpChannelTextMessageType));

removed (squashed).

> + * Check if message of type @type can be send on this channel.
> 
>                                           ^^^^ should be ‘sent’
> 
> ditto the next line.

fixed (squashed).

yup!

Merged to master; will be in 0.13.16.