Bug 34946

Summary: [PATCH] handle consolidated NM 0.9 modem types
Product: PackageKit Reporter: Dan Williams <dcbw>
Component: GeneralAssignee: Richard Hughes <richard>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Fixups for NM 0.9

Description Dan Williams 2011-03-02 15:33:13 UTC 
Created attachment 44040 [details] [review]
Fixups for NM 0.9

In NM 0.9, modem types are consolidated as breaking them out into GSM and CDMA doesn't work for multi-family devices, like ones that support both GSM and CDMA, and CDMA and LTE or GSM and LTE, etc.

I've pushed a patch to NM for both 0.8.x and 0.9 that adds a NM_CHECK_VERSION define, so use that if we can, otherwise fall back.

Also, support for WiMAX devices was added; treat that as metered mobile broadband.
Comment 1 Richard Hughes 2011-03-03 03:13:50 UTC 
I've already fixed this in:

commit a9babc28659365f1c127f588b18c0ebad19d0f1a
Author: Richard Hughes <richard@hughsie.com>
Date:   Mon Feb 28 10:46:12 2011 +0000

    Work with NetworkManager >= 0.8.992 which has removed two enumerated types

:100644 100644 4744bf5... 76a75ed... M  configure.ac
:100644 100644 bb34d16... 4b0889d... M  src/pk-network-stack-nm.c

But your patch is much better than mine, so I'll revert what I've got an use yours instead. Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.