Bug 34964

Depends on bug #32267 and the spec being merged and released blah blah blah you know the boring drill.

What do you think about this wording for the doc ?


/**
 * tp_base_client_set_observer_delay_approvers:
 * @self: a #TpBaseClient
 * @delay: the value of the Observer.DelayApprovers property
 *
 * Set whether the channel dispatcher should wait for
 * #TpBaseClientClass.observe_channels to return before calling
 * #TpBaseClientClass.add_dispatch_operation on appropriate Approvers.
 *
 * This is implemented by setting the value of the DelayApprovers
 * D-Bus property.
 *
 * This method may only be called before tp_base_client_register() is
 * called, and may only be called on objects whose class implements
 * #TpBaseClientClass.observe_channels.
 *
 * Since: 0.13.UNRELEASED
 */

I added a test to your branch: http://git.collabora.co.uk/?p=user/cassidy/telepathy-glib;a=shortlog;h=refs/heads/delay-approvers-34964

Btw, your commit actually break the test as get_observer_prop_cb checks the number of Observer properties announced. So we should idally squash these 2 commits together.

(In reply to comment #2)
>  * Set whether the channel dispatcher should wait for
>  * #TpBaseClientClass.observe_channels to return before calling
>  * #TpBaseClientClass.add_dispatch_operation on appropriate Approvers.

But ObserveChannels doesn't return when TpBaseClientClass.observe_channels returns, it's when one of the tp_observe_channels_context_* functions is called.

Other than that it looks fine. Sorry for breaking the test!

Fixed in the new version of the branch. I'll merge it once we have a spec release out and tp-glib has been synced to it.

spec released. Merged, will be in 0.13.16.