| Summary: | Segfault in fc-cache | ||
|---|---|---|---|
| Product: | fontconfig | Reporter: | Owen Taylor <otaylor> |
| Component: | fc-cache | Assignee: | Keith Packard <keithp> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | high | ||
| Version: | 2_1 | ||
| Hardware: | x86 (IA32) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Oops. Forgot to commit the fix for this... |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
fc-cache segfaults within FcDirScan() because FcDirScan() does: if (FcDirCacheReadDir (set, dirs, dir)) { FcGlobalCacheReferenceSubdir (cache, dir); return FcTrue; } But cache can be NULL. Adding a if (cache) before calling ReferenceSubdir() looks right and tests to fix the problem. [ Reproduction: touch /usr/share/fonts/ja/Default touch /usr/share/fonts/ja touch /usr/share/fonts fc-list fc-cache /usr/share/fonts/ja Probably can be made a lot more minimal, but the fix was obvious ]