Bug 35012

Summary:	Think a bit harder about ICE restarts
Product:	Telepathy	Reporter:	David Laban <david.laban>
Component:	tp-spec	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	david.laban, olivier.crete, sjoerd
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:	Call
i915 platform:		i915 features:
Bug Depends on:	28705
Bug Blocks:	29590

Description David Laban 2011-03-04 05:07:52 UTC

+++ This bug was initially created as a clone of Bug #28705 +++

I decided to split this out as a separate bug and give it its own branch, so I can merge some of the other stuff from #28705. Below is the discussion that has been had on the issue so far.

>> Maybe PleaseRestartICE() should have a matching property for recoverability?
> Haven't addressed this. Could this be done by exposing the CM's view of the
> state machine for the stream, or would you say that it is orthogonal? Also, you
> say that LocalCredentials is mostly useful for debugging. Could we just set it
> to "", "" but not clear LocalCandidates when we emit PleaseRestartIce?

<alsuren> ocrete: what do you think of http://git.collabora.co.uk/?p=user/alsuren/telepathy-spec.git;a=shortlog;h=refs/heads/IceRestarts ?
<alsuren> ocrete: if LocalCredentials is looking too much like conflated design then I'm happy to scrap that commit, and add a property tomorrow

<ocrete> why do we clear the local cands on a ice restart ?
<ocrete> don'T have to do that
<ocrete> they shouldnt change
<alsuren> ocrete: if we are a gateway then the controlling endpoint might have changed?
<alsuren> though other things probably break in that use case
<alsuren> mostly just me getting confused with RemoteCandidates
<ocrete> hmm maybe

Comment 1 David Laban 2011-07-01 17:07:18 UTC

Clearing local candidates on ice restart isn't actually that costly. The streaming implementation can just re-add them if it wants.

Did some renaming as discussed in #38852. I also like my ICERestartPending bool, and the idea that the whole process can be observable/debugable. It seems silly to throw away something that we can get pretty-much for free.

http://cgit.collabora.com/git/user/alsuren/telepathy-spec.git/log/?h=ice-restarts-35012 should be ready for review. If you want me to squash some commits together then I can.

Comment 2 Olivier Crête 2011-07-05 12:33:35 UTC

++

Comment 3 David Laban 2011-07-05 13:08:01 UTC

merged to alsuren/call

Comment 4 David Laban 2011-07-19 12:47:56 UTC

merged to master

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.