| Summary: | Should send keep-alive packets to detect dropped connections. | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Sjoerd Simons <sjoerd> |
| Component: | idle | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | danielle |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Send keep alive packets
Send keep alive packets Send keep alive packets Send keep alive packets |
||
|
Description
Sjoerd Simons
2011-03-06 04:04:50 UTC
Created attachment 45016 [details] [review] Send keep alive packets XChat-GNOME tries to obfuscate the timestamp a bit: GTimeVal timev; g_get_current_time (&timev); return (timev.tv_sec - 50000) * 1000000 + timev.tv_usec; This is probably a lame attempt at maintaining the privacy of the user by hiding the actual time at his end. Created attachment 45702 [details] [review] Send keep alive packets The interval is now configurable. A new parameter keepalive-interval similar to the one in Gabble has been added. Created attachment 45704 [details] [review] Send keep alive packets Updated data/idle.manager. Review of attachment 45704 [details] [review]: ::: src/idle-connection.c @@ +24,3 @@ #include <config.h> +#include <inttypes.h> Unneeded, see below. @@ +753,3 @@ } +static void _send_with_priority(IdleConnection *conn, const gchar *msg, guint priority); I don't think this should be in the middle of the file. Put it at the top. @@ +767,3 @@ + + ping_time = g_get_real_time(); + gint64 ping_time; Use G_GINT64_FORMAT instead of PRId64 Created attachment 45842 [details] [review] Send keep alive packets Fixed as suggested in the review. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.