| Summary: | Need an error type for indicating lack of support for emergency numbers | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Jonathon Jongsma <jonathon> |
| Component: | tp-spec | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | danielle |
| Version: | git master | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
patch
Add EmergencyCallsNotSupported error Add EmergencyCallsNotSupported error Add EmergencyCallsNotSupported error |
||
|
Description
Jonathon Jongsma
2011-03-07 15:28:49 UTC
Created attachment 44214 [details] [review] patch Review of attachment 44214 [details] [review]: ::: spec/errors.xml @@ +551,3 @@ + not support dialling emergency numbers. + </tp:docstring> + <tp:rationale> tp:rationale should be inside tp:docstring. Comment on attachment 44214 [details] [review] patch It's not necessarily the CM, your voip to pstn provider might not support this. Would be nice to clarify the rationale in some way to say that a lot of providers do not support this. One example being Google voice (http://www.google.com/googlevoice/legal-notices.html first item) Created attachment 44233 [details] [review] Add EmergencyCallsNotSupported error https://bugs.freedesktop.org/show_bug.cgi?id=35100 Created attachment 44234 [details] [review] Add EmergencyCallsNotSupported error Created attachment 44240 [details] [review] Add EmergencyCallsNotSupported error Comment on attachment 44234 [details] [review] Add EmergencyCallsNotSupported error one more time, with correct name this time. Looks good to me, wjt might want to have a quick look (it's late and i might have missed something :p) Merged, thanks!. A fresh spec has just released and a new telepathy-glib release should be out soon |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.