Bug 35118

I agree with the analysis.  But not the solution.  How about we change FcLangCompare() to return a new FcLangMaybeDifferentTerritory if one lang has a territory and the other doesn't?  Would have been nice if we could define that .5, but not a huge deal.  The matcher has to order them.

Humm, I tried, but it's kinda in the API that FcLangCompare results are monotonic.   So much approach wouldn't work.  Let me see what else I can come up with.

*** Bug 26604 has been marked as a duplicate of this bug. ***

I could rework this patch to use, say four *internal* values of, e.g.

FcInternalLangEqual,
FcInternalLangDefaultCountry, (or NoCountry, whatever)
FcInternalLangDifferentCountry,
FcInternalLangDifferentLanguage, 

everywhere internally, and then map them at the api entry/exit points to the public

FcLangEqual
FcLangDifferentCountry
FcLangDifferentLanguage

if that was considered useful

I fixed an embarrassing bug in language handling.  Can you please retest with master?

Behdad, did you push it to the repo?

Oops.  Done now:

http://cgit.freedesktop.org/fontconfig/commit/?id=bf3bfa72d91e8bc37903d7e1bb7ac23c6ef4952a

just tried ja vs ja-jp but not the case in comment#0.

I don't see any difference between fc-match serif:lang=ja and fc-match serif:lang=ja-jp say though, does this change expect to see any changes on output even if the config files doesn't contain <test name="lang"><string>ja-jp</string></test> but <string>ja</string>?

(In reply to comment #8)
> just tried ja vs ja-jp but not the case in comment#0.
> 
> I don't see any difference between fc-match serif:lang=ja and fc-match
> serif:lang=ja-jp say though, does this change expect to see any changes on
> output even if the config files doesn't contain <test
> name="lang"><string>ja-jp</string></test> but <string>ja</string>?

Reading bug description again and thinking about it, the bug is still there.  May be able to resolve it by just changing FcCompareLang() to use FcLangSetContains family of operators.  That goes against the design of the matcher, but will work.

(In reply to comment #9)
> Reading bug description again and thinking about it, the bug is still there. 
> May be able to resolve it by just changing FcCompareLang() to use
> FcLangSetContains family of operators.  That goes against the design of the
> matcher, but will work.

So modifying the config file to:

<test name="family" compare="contains">
  <string>ja</string>
</test>

will works then? okay, let me try..

(In reply to comment #10)
> (In reply to comment #9)
> > Reading bug description again and thinking about it, the bug is still there. 
> > May be able to resolve it by just changing FcCompareLang() to use
> > FcLangSetContains family of operators.  That goes against the design of the
> > matcher, but will work.
> 
> So modifying the config file to:
> 
> <test name="family" compare="contains">

You mean name="lang".

>   <string>ja</string>
> </test>
> 
> will works then? okay, let me try..

Yes, that should work I guess.

Well, I missed the way to reproduce this on ja vs ja-jp and there seems different reason to not matching on pa-pk as per comment#0. so I failed to confirm if compare="contains" would really help.

From current implementation of the orthography, pa and pa-pk has different requirements to sasitfy. pa_pk.orth is referring to ur.orth through lah.orth now and it's obvious pa.orth and ur.orth requires different scripts coverage. given this is correct, not matching Lohit Punjabi on fc-match :lang=pa-pk would means not a bug then.

needing more info or feedback.

For another solution, I have implemented FcLangNormalize() function to fit into the language tag that fontconfig actually supports. for instance, it expects to get "ja" with FcLangNormalize("ja-jp"). this is however currently exported as the internal use only. so if it's useful, we can make it public perhaps.

Shall we revisit this.  I have to read the report again to understand what this was about.

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/fontconfig/fontconfig/issues/30.