Bug 35149

Summary:

modes unassigned to outputs not shown distinctly

Product:

xorg

Reporter:

chrysn <chrysn>

Component:

App/xrandr

Assignee:

Keith Packard <keithp>

Status:

RESOLVED MOVED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

trivial

Priority:

low

CC:

jeremyhu

Version:

git

Keywords:

patch

Hardware:

Other

OS:

All

Whiteboard:

2011BRB_Reviewed

i915 platform:

i915 features:

Attachments:

Description	Flags
a simple patch for the bug	none
code refactoring	none
a simple patch for the bug	none
code refactoring	none
a simple patch for the bug	none
code refactoring	none

Description chrysn 2011-03-09 06:02:34 UTC

in verbose mode, there is no way to tell modes that are not assigned to any output apart from modes that are assigned to the last output.

i suggest that `if (res->nmode > 0)` around xrandr.c:3221 (line numbers as of git d58d70f6), a message like "Not assigned to any output:\n" should be printed.

(due to what i guess is a bug, it *is* currently possible to tell them apart under some circumstances -- the code blocks xrandr:3161-3184 and 3221:3237 are identical but for "current"/"preferred" messages (which don't apply to unassigned modes) and the [+-][HV]Sync flags which i assume were just forgotten to add to the unassigned outputs)

the distinction between unassigned modes and modes assigned to the last output can also be made in non-verbose mode, where the unassigned modes are shown in a more detailled way (as in verbose); nevertheless, the same message should also be shown there to avoid confusion.

while the overall severity of this is rather low, this is a severe program for tools that parse xrandr output (which is, i have to admit, not what xrandr is designed for).

Comment 1 Jeremy Huddleston Sequoia 2011-10-08 19:36:34 UTC

Line numbers change.  Patches are better since it makes it more clear what 
you're talking about.

Comment 2 chrysn 2011-10-09 15:25:30 UTC

Created attachment 52158 [details] [review]
a simple patch for the bug

Comment 3 chrysn 2011-10-09 15:50:11 UTC

Created attachment 52159 [details] [review]
code refactoring

i'm not sure if it follows the coding conventions completely (especially, i'm confused about whitespace handling), but it appears to be functional (flags show up now in unassigned outputs).

Comment 4 chrysn 2012-07-09 14:54:34 UTC

Created attachment 64026 [details] [review]
a simple patch for the bug

enhanced version of the patch; the old one was erroneous in that it showed the message unconditionally. also rebased onto current master.

Comment 5 chrysn 2012-07-09 14:55:44 UTC

Created attachment 64027 [details] [review]
code refactoring

rebased onto new "simple patch for the bug"

Comment 6 chrysn 2012-07-09 15:00:47 UTC

unless there are good reasons against it, please only apply the two patches together, as i can thus use the missing flags to tell the assigned from the unassigned modes in older versions.

Comment 7 chrysn 2014-12-24 00:30:33 UTC

Created attachment 111248 [details] [review]
a simple patch for the bug

Comment 8 chrysn 2014-12-24 00:31:33 UTC

Created attachment 111249 [details] [review]
code refactoring

those two new patches are the last versions rebased onto current master.

Comment 9 GitLab Migration User 2018-08-10 20:33:37 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/app/xrandr/issues/11.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.