Bug 35205

Branch updated for latest master and blah blah blah.

Even made the function part of public API so plugins can use it.

im-manager: only deal with messages for this manager
We only like no subtype and subtype="chat" messages.

+  wocky_stanza_get_type_info (stanza, NULL, &sub_type);
+
+  /* we only handle messages without a sub type here */
+  if (sub_type != WOCKY_STANZA_SUB_TYPE_NONE
+      && sub_type != WOCKY_STANZA_SUB_TYPE_CHAT)
+    return FALSE;

the commit message, comment and code don't agree.

Also, what about type='error'? and type='headline'? They're perfectly reasonable types for messages. I think this is secret code for using a higher-priority handler for pubsub event messages, maybe?

Why does salut_send_ll_pep_event() have two different local variables for the contact factory?

You could extract send_ll_pep_event_to_contact (WockyLLContact *, WockyStanza *) to reduce the code duplication between the loop and the self-contact blocks.

(In reply to comment #2)
> I think this is secret code for using a
> higher-priority handler for pubsub event messages, maybe?

OK.

> Why does salut_send_ll_pep_event() have two different local variables for the
> contact factory?

Odd, fixed.

> You could extract send_ll_pep_event_to_contact (WockyLLContact *, WockyStanza
> *) to reduce the code duplication between the loop and the self-contact blocks.

Yeah, done.

Updated. Some other related little things fixed in this branch too.

Perfetto.