Bug 3526

Summary: XawInit.h should include Instrinsic.h
Product: xorg Reporter: Daniel Stone <daniel>
Component: Lib/XawAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: high Keywords: patch
Version: 6.8.2   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Proposed patch none

Description FreeDesktop Bugzilla Database Corruption Fix User 2005-06-12 07:22:05 UTC 
rev 1.2 in the xorg cvs of XawInit.h introduced the XawOpenApplication widget.
To be consistent, the header should now have enough inclusions to provide the
definition of a widget.  <Intrinsic.h> seems to do the trick.  Probably not
going to be a problem for real apps, which likely already have all the includes,
but broke some configure-script features tests to see if Xaw was sane.
Comment 1 Shawn Starr 2005-10-04 18:45:02 UTC 
Why exactly to build it?
Comment 2 Mats Wichmann 2006-02-08 09:02:17 UTC 
What happened to this bug?  The contents seem to have vanished.  If XawInit.h is
used for configure checks (odd, but true, it happens:
AC_CHECK_HEADER(X11/Xaw/XawInit.h) has been spotted in the wild) the fact that
it's not self-contained means "extern Widget XawOpenApplication" refers to stuff
that's unknown to the compiler.
Comment 3 Alan Coopersmith 2006-02-08 09:55:03 UTC 
The freedesktop bugzilla database was corrupted in a disk crash last summer, and
the contents of some bugs were lost - this was one, which was why it was marked
"[BROKEN BUG]" until someone could restore the original contents/request/report.
Comment 4 Mats Wichmann 2006-03-07 01:26:10 UTC 
I've done that.  I'm clicking the Reassign button so it goes out of NEEDINFO 
state for now.
Comment 5 Daniel Stone 2007-02-27 01:27:02 UTC 
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 6 Cyril Brulebois 2010-10-27 15:39:29 UTC 
Created attachment 39822 [details] [review]
Proposed patch

<X11/Intrinsic.h> looks like a good candidate indeed. A trivial test program now compiles successfully.
Comment 7 Alan Coopersmith 2010-10-27 21:58:47 UTC 
Thanks for the patch, pushed to git master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.