Bug 35711

Created attachment 44903 [details] [review]
Remove the calls to plymouth message

* messages aren't translated
 * console text is ugly
 * they are jargonny
 * they really aren't needed

Uh, should this really go away on the lowest level? 

if the messages currently aren't translated, then the obvious fix appears to be to make them translatable. 

They aren't shown as "console text", but by Plymouth' freetype support.

I'd much rather see this turned off in the theme somehow.

I'm assuming you added those messages because that's what Fedora did before systemd and you were trying to maintain status quo.  Note:

1) Jon was the person who added those messages to Fedora originally
2) When they were in Fedora they were translated
3) I totally agree with you that this would be better done at the theme level.  So I think you're both right.  The generic plymouth message calls should be removed, and themes that want the message can just add it themselves.

We do have one problem here that plymouth doesn't have any generic way to distinguish between shutdown and reboot.  We could fix that in plymouth by having a new mode passed to plymouthd.

In the mean time, themes that care about those messages can probably hook off the update status coming in.

s/When they were in Fedora/When they were originally added to initscripts in Fedora/

(In reply to comment #3)
> I'm assuming you added those messages because that's what Fedora did before
> systemd and you were trying to maintain status quo.  

Yes.

> Note:
> 
> 1) Jon was the person who added those messages to Fedora originally
> 2) When they were in Fedora they were translated
> 3) I totally agree with you that this would be better done at the theme level. 
> So I think you're both right.  The generic plymouth message calls should be
> removed, and themes that want the message can just add it themselves.
> 
> We do have one problem here that plymouth doesn't have any generic way to
> distinguish between shutdown and reboot.  We could fix that in plymouth by
> having a new mode passed to plymouthd.

Sounds good. Note that systemd by default offers four shutdown modes: poweroff, halt, reboot, kexec. 

I figure poweroff+halt and reboot+kexec need not to be distuingished in Plymouth, hence it would be cool if we could do "/sbin/plymouthd --mode=reboot" and "/sbin/plymouthd --mode=halt" from systemd and the themes add it in.
 
> In the mean time, themes that care about those messages can probably hook off
> the update status coming in.

Hmmm? I don't follow?

(anyway, I will now apply Jon's patch, and reassign this to Plymouth, so that we get those two new modes.)

The patch is now merged, reassigning to plymouth so that we get those new modes.

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/plymouth/plymouth/issues/12.