Bug 3578

Xcompmgr appears to continually leak memory - when run under memprof, the memory
usage increased to several megabytes in a few minutes.

The set_ignore function, called from print_all, malloc's memory and attaches it
to a linked list.  Every iteration of print_all calls this function, which means
if a window is changing, a few bytes of memory are allocated several times a second.
The list appears to only be deleted (from discard_ignore) when a new window
appears (something I noticed when a tooltip appears over memprof's 'leak' button).

In the main loop (line 2063), discard_ignore is called only when (ev.type & 0x7f
!= KeymapNotify).  If this if statement is removed, allowing discard_ignore to
always run, the memory usage remains below 64k, and doesn't continually increase. 

I don't have time to determine if that's just a bad hack, but it works for me.


There's also a memory leak in determine_wintype, line 1407, where the function
returns without having freed data.


The following patch fixes both:


Index: xcompmgr.c
===================================================================
RCS file: /cvs/xapps/xcompmgr/xcompmgr.c,v
retrieving revision 1.39
diff -r1.39 xcompmgr.c
1405a1406,1407
>       {
>               XFree ((void *)children);
1406a1409
>       }
2059c2062
<           if (ev.type & 0x7f != KeymapNotify)
---
>           //if (ev.type & 0x7f != KeymapNotify)