Bug 35822

Summary:	[bisected pineview] many cases related to depth and stencil failed
Product:	Mesa	Reporter:	fangxun <xunx.fang>
Component:	Drivers/DRI/i915	Assignee:	Chris Wilson <chris>
Status:	VERIFIED FIXED	QA Contact:
Severity:	major
Priority:	medium	CC:	chris
Version:	git
Hardware:	All
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description fangxun 2011-03-31 01:08:49 UTC

System Environment:
--------------------------
Arch:           i386
Platform:       Pineview
Libdrm: (master)2.4.24-9-g5cb554a0d6e986f2d7300a91d95983fa09b17f65
Mesa:   (master)5eb9f687087a4bc71775a32efcd848fc6cd67694
Xserver:(master)xorg-server-1.10.0-143-g327e1d88012102af6aca6c6840aa0ed3c7041a77
Xf86_video_intel:(master)2.14.902-2-g630d77bf10ba6234bb9c04538636f7d8aa319aea
Kernel: (drm-intel-next)f0c860246472248a534656d6cdbed5a36d1feb2e

Bug detailed description:
-------------------------
There many piglit and olgc cases that related to depth and stencil failed.
Following are part of those failed cases: 
piglit: general/depthrange-clear,  glean/fp1-Z-write_test, glean/glsl1-gl_FragDepth_writing, general/scissor-depth-clear, general/scissor-stencil-clear
oglc: pxzoom-stencil, depth-stencil(advanced.packed_depth_stencil_fetch.tex).
ogles2: GL2ExtensionTests_depth_texture_depth_texture.test

Bisect shows 7bae1c3d85344b7229e0124d1f54376392682430 is the first bad commit. commit 7bae1c3d85344b7229e0124d1f54376392682430
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue Mar 29 15:40:21 2011 +0100

    intel: Protect intel_clear_with_blit from failed buffer allocations
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=34419
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
.

Comment 1 Chris Wilson 2011-03-31 02:58:28 UTC

Maybe I'm doing something wrong here, but:

CLI options echo:
oglconform -test pxzoom-stencil -v 2 -D 33 -s 

WARNING: OpenCL is not supported.
Pixel format 33
GLX_USE_GL:          Yes
GLX_BUFFER_SIZE:     32
GLX_LEVEL:           0
GLX_RGBA:            Yes
GLX_DOUBLEBUFFER:    Yes
GLX_STEREO:          No
GLX_AUX_BUFFERS      0
GLX_RED_SIZE         8
GLX_GREEN_SIZE       8
GLX_BLUE_SIZE        8
GLX_ALPHA_SIZE       8
GLX_DEPTH_SIZE       24
GLX_STENCIL_SIZE     8
GLX_ACCUM_RED_SIZE   0
GLX_ACCUM_GREEN_SIZE 0
GLX_ACCUM_BLUE_SIZE  0
GLX_ACCUM_ALPHA_SIZE 0

Setup Report.
    Verbose level = 2.
    Path inactive.

Visual Report.
    Display ID = 33. 
    Double Buffered.
    RGBA (8, 8, 8, 8).
    Stencil (8).
    Depth (24).
    Accumulation (0, 0, 0, 0).
    0 Auxilary Buffers.

OpenGL Report.
    Vendor - 'Tungsten Graphics, Inc'
    Renderer - 'Mesa DRI Intel(R) IGD GEM 20100330 DEVELOPMENT x86/MMX/SSE2'
    Version - '1.4 Mesa 7.11-devel'

    Double Buffered.
    RGBA (8, 8, 8, 8).
    Stencil (8).
    Depth (24).
    Accumulation (0, 0, 0, 0).
    0 Auxilary Buffers.

OpenGL Report.
    Vendor - 'Tungsten Graphics, Inc'
    Renderer - 'Mesa DRI Intel(R) IGD GEM 20100330 DEVELOPMENT x86/MMX/SSE2'
    Version - '1.4 Mesa 7.11-devel'


>> Stencil Zoom (pxzoom-stencil)  test:
<< Stencil Zoom (pxzoom-stencil)  test passed.
TIME DATA: pxzoom-stencil = 2.043 seconds.

Comment 2 Chris Wilson 2011-03-31 04:01:00 UTC

Oh my bad. I failed to actually build the right version of mesa when testing.

commit c40b7910ee1338b9d391816df5391ce43f509ef0
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Mar 31 11:41:46 2011 +0100

    intel: Fix regression in clear_with_blit from 7bae1c3d
    
    Oops, the mask was being used in the loop to determine whether to use
    include the stencil || depth values. This began to fail when mask was
    cleared at the beginning of the loop. So reorder the tests and do the
    work up-front along with determining the depth_stencil value to use.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=35822
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Comment 3 fangxun 2011-03-31 22:23:41 UTC

Verified with commit c40b7910ee1338b9d391816df5391ce43f509ef0.
BTW, piglit fbo/fbo-depth-sample-compare always fails before commit 7bae1c3. When other depth cases failed due to commit 7bae1c3, it passed. When c40b79 fix the regression, all other failed depth cases passed, and this case failed again. Maybe this info is useful for fixing this case.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.