Bug 35968

Summary:	use localhost for tests
Product:	Telepathy	Reporter:	Paul Seidler <pl.seidler>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	0.10
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch to use localhost for tests

Description Paul Seidler 2011-04-04 14:56:34 UTC

Created attachment 45242 [details] [review]
patch to use localhost for tests

Tests should be bind to localhost wherever possible for security reasons. Think of a test which don't exits correctly and let a port open for attacks. I've created a patch for 0.10.5, which correct this for some tests. There is still a bind to 0.0.0.0 in test-fallback-socks5-proxy.py which I can't find easily.

Comment 1 Will Thompson 2011-07-28 08:20:34 UTC

Thanks! I merged this to master <http://cgit.freedesktop.org/telepathy/telepathy-gabble/commit/?id=885d9cd> and added a further patch which I think should address the issue in test-fallback-socks5-proxy.py <http://cgit.freedesktop.org/telepathy/telepathy-gabble/commit/?id=2ec472c>.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.