| Summary: | TpProtocol: add avatar support | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Guillaume Desmottes <guillaume.desmottes> |
| Component: | tp-glib | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | enhancement | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=protocol-avatar-36049 | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
| Bug Depends on: | 36134 | ||
| Bug Blocks: | |||
| Attachments: | TpProtocol: add API to get avatars requirements (fdo #36049) | ||
|
Description
Guillaume Desmottes
2011-04-07 06:00:51 UTC
http://git.collabora.co.uk/?p=user/cassidy/telepathy-glib;a=shortlog;h=refs/heads/protocol-avatar-36049 Note that I wasn't able to test this with a real life CM as none seems to implement this interface atm. Created attachment 45535 [details] [review] TpProtocol: add API to get avatars requirements (fdo #36049) Review of attachment 45535 [details] [review]: this looks fine. ::: tests/dbus/protocol-objects.c @@ +345,3 @@ + g_assert_cmpuint (req->maximum_width, ==, 96); + g_assert_cmpuint (req->maximum_height, ==, 96); + "image/jpeg")); Where did this number come from? (In reply to comment #3) > Review of attachment 45535 [details] [review]: > > this looks fine. > > ::: tests/dbus/protocol-objects.c > @@ +345,3 @@ > + g_assert_cmpuint (req->maximum_width, ==, 96); > + g_assert_cmpuint (req->maximum_height, ==, 96); > + "image/jpeg")); > > Where did this number come from? Grr splinter. The number I was referring to was the massive number of maximum bytes. (In reply to comment #4) > (In reply to comment #3) > > Review of attachment 45535 [details] [review] [details]: > > > > this looks fine. > > > > ::: tests/dbus/protocol-objects.c > > @@ +345,3 @@ > > + g_assert_cmpuint (req->maximum_width, ==, 96); > > + g_assert_cmpuint (req->maximum_height, ==, 96); > > + "image/jpeg")); > > > > Where did this number come from? > > Grr splinter. The number I was referring to was the massive number of maximum > bytes. That's the number already used in examples/cm/echo-message-parts/protocol.c Merged to master; will be in 0.15.6 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.