Bug 36049

Summary: TpProtocol: add avatar support
Product: Telepathy Reporter: Guillaume Desmottes <guillaume.desmottes>
Component: tp-glibAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: enhancement    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: Other   
OS: All   
URL: http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=protocol-avatar-36049
Whiteboard: review+
i915 platform: i915 features:
Bug Depends on: 36134    
Bug Blocks:    
Attachments: TpProtocol: add API to get avatars requirements (fdo #36049)

Description Guillaume Desmottes 2011-04-07 06:00:51 UTC
TpProtocol should have API to access http://telepathy.freedesktop.org/spec/Protocol_Interface_Avatars.html
Comment 1 Guillaume Desmottes 2011-04-12 08:38:29 UTC
http://git.collabora.co.uk/?p=user/cassidy/telepathy-glib;a=shortlog;h=refs/heads/protocol-avatar-36049

Note that I wasn't able to test this with a real life CM as none seems to implement this interface atm.
Comment 2 Guillaume Desmottes 2011-04-12 08:40:39 UTC
Created attachment 45535 [details] [review]
TpProtocol: add API to get avatars requirements (fdo #36049)
Comment 3 Will Thompson 2011-07-25 09:07:05 UTC
Review of attachment 45535 [details] [review]:

this looks fine.

::: tests/dbus/protocol-objects.c
@@ +345,3 @@
+  g_assert_cmpuint (req->maximum_width, ==, 96);
+  g_assert_cmpuint (req->maximum_height, ==, 96);
+        "image/jpeg"));

Where did this number come from?
Comment 4 Will Thompson 2011-07-25 09:10:23 UTC
(In reply to comment #3)
> Review of attachment 45535 [details] [review]:
> 
> this looks fine.
> 
> ::: tests/dbus/protocol-objects.c
> @@ +345,3 @@
> +  g_assert_cmpuint (req->maximum_width, ==, 96);
> +  g_assert_cmpuint (req->maximum_height, ==, 96);
> +        "image/jpeg"));
> 
> Where did this number come from?

Grr splinter. The number I was referring to was the massive number of maximum bytes.
Comment 5 Guillaume Desmottes 2011-08-29 05:08:11 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Review of attachment 45535 [details] [review] [details]:
> > 
> > this looks fine.
> > 
> > ::: tests/dbus/protocol-objects.c
> > @@ +345,3 @@
> > +  g_assert_cmpuint (req->maximum_width, ==, 96);
> > +  g_assert_cmpuint (req->maximum_height, ==, 96);
> > +        "image/jpeg"));
> > 
> > Where did this number come from?
> 
> Grr splinter. The number I was referring to was the massive number of maximum
> bytes.

That's the number already used in examples/cm/echo-message-parts/protocol.c
Comment 6 Guillaume Desmottes 2011-08-29 05:15:25 UTC
Merged to master; will be in 0.15.6

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.