Bug 36110

Agreed. Would be cool if you could provide a separated branch so we can review/merge that without blocking on the whole TpFileTransferChannel.

+  // Find best socket address type

Please use /* C89 comments */ rather than // C99 comments (despite it being 2011).

This kind of comment belongs in a block above the function:

/*
 * _tp_determine_socket_address_type:
 *
 * Determines the best-available socket address type.
 */
TpSocketAddressType
_tp_determine_socket_address_type (GHashTable *supported_sockets,
    GError **error)

or similar.

I notice that you've actually moved these functions over almost verbatim from telepathy-glib/stream-tube-channel.c but changed the commenting style and removing the pre-function block comment from find_best_access_control() which had slightly more information. :) I'd personally prefer patches that move code to be joined together, to make it clear that the code's been moved, rather than apparently being written from scratch and then later discovering that the same code was removed from another file.

The branching in the code is a bit weird: both _tp_determine_socket_address_type and _tp_determine_access_control_type have a lot of duplication.

+  self->priv->socket_type = _tp_determine_socket_address_type (
+      supported_sockets, &error);
+  self->priv->access_control = _tp_determine_access_control_type (
+      supported_sockets, self->priv->socket_type, &error);

This is wrong: you can't pass 'error' to the second function without having checked that the first function returned success.

Any particular reason for removing the more-specific DEBUG() output from the error paths of create_client_socket? Previously the message told the developer immediately at what stage the error occurred; now it does not.

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-glib/issues/61.