|
Description
Guillaume Desmottes
2011-04-11 08:06:13 UTC
Created attachment 45478 [details] [review] TpProtocol: add supported interfaces (fdo #36134) Created attachment 45513 [details] [review] add tp_proxy_add_interfaces() Created attachment 45514 [details] [review] use _tp_proxy_add_interfaces() Created attachment 45515 [details] [review] TpProtocol: add supported interfaces (fdo #36134) Created attachment 45522 [details] [review] tp_proxy_add_interfaces: improve debug message Created attachment 45523 [details] [review] tp_proxy_add_interfaces: interfaces is a 'const gchar * const *' Created attachment 45524 [details] [review] More use tp_proxy_add_interfaces() Created attachment 45525 [details] [review] TpProtocol: add supported interfaces (fdo #36134) Review of attachment 45522 [details] [review]: yup. Review of attachment 45523 [details] [review]: ::: telepathy-glib/proxy.c @@ +659,3 @@ return; + for (iter = (const gchar **) interfaces; *iter != NULL; iter++) no, you should change the type of 'iter' rather than casting interfaces. Review of attachment 45524 [details] [review]: “More use tp_proxy_add_interfaces” isn't English. “Use tp_proxy_add_interfaces() more [widely]” is. ::: telepathy-glib/account.c @@ +469,2 @@ + interfaces = tp_asv_get_boxed (properties, "Interfaces", G_TYPE_STRV); + tp_proxy_add_interfaces (proxy, interfaces); This could even become tp_proxy_add_interfaces (proxy, tp_asv_get_strv (properties, "Interfaces")); ::: telepathy-glib/connection-manager.c @@ +708,2 @@ tp_connection_manager_add_interfaces (TpConnectionManager *self, const gchar * const * interfaces) This function doesn't do anything else, and isn't API, so just delete it? Review of attachment 45525 [details] [review]: aye aye cap'n Created attachment 45526 [details] [review] tp_proxy_add_interfaces: interfaces is a 'const gchar * const *' Comment on attachment 45523 [details] [review] tp_proxy_add_interfaces: interfaces is a 'const gchar * const *' fixed Created attachment 45527 [details] [review] Use tp_proxy_add_interfaces() more Review of attachment 45526 [details] [review]: 👍 Review of attachment 45527 [details] [review]: ✓ Merged to 0.14 and master. Will be in 0.14.4 and 0.15.0. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.