Bug 36191

Summary: remove mapping of il(si1452) -> ie(basic)
Product: xkeyboard-config Reporter: Shai Berger <shai>
Component: GeneralAssignee: xkb
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Shai Berger 2011-04-12 16:09:47 UTC 
Hi,

Compat (rules/compat/variantsMapping.lst) currently contains a mapping from il(si1452) to ie(basic). This is wrong, and should be removed. 

It is wrong because the Israeli si1452 variant was nothing like any Irish mapping. The mapping was introduced in http://cgit.freedesktop.org/xkeyboard-config/commit/?id=82b2fc19c995dc2c2dbaf9912b716dc4d91ff61d while fixing #6375, in 2006, with comment 3 in that bug implying a mapping to il(basic), so ie(basic) is probably just a typo introduced at some stage.

It should be removed, because -- since the broken mapping has persisted unchanged in five years -- it seems safe to say that nobody is referring to the variant by that name anymore.

The issue comes up because a new version of the SI1452 standard is in the works, and people who have tried the new variant drafts under the name si1452 ran into serious breakage.

This bug is the off-shoot of Debian bug http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=621706
Comment 1 Sergey V. Udaltsov 2011-04-12 16:10:52 UTC 
It was most probably a typo. Could that be il(basic)?
Comment 2 Sergey V. Udaltsov 2011-04-12 16:11:54 UTC 
And once new si1452 is available, we could remove that mapping and create proper variant...
Comment 3 Shai Berger 2011-04-12 16:15:38 UTC 
The point is that the mapping is getting in the way already. We don't need to wait for the new si1452 to remove it.
Comment 4 Sergey V. Udaltsov 2011-04-12 16:22:02 UTC 
What would happen if user chooses layout il(si1452)? There is no variant for now. This variantMapping.lst is used for variants that existed but were renamed at some point.
Comment 5 Shai Berger 2011-04-12 16:48:29 UTC 
As I wrote in the original bug report, nobody has been able to do that without breakage since 2006. The only people who choose il(si1452) are people who wish to try out the new standard draft, which means that they add their own variant si1452 and are surprised to see that it doesn't work.

Or, in other words: Removing this mapping now will break nothing. It will only remove some breakage.
Comment 6 Shai Berger 2011-04-12 16:51:56 UTC 
BTW, the referenced commit also removed si1452 from the XML files, so you can only choose si1452 by manually editing your config files.
Comment 7 Sergey V. Udaltsov 2011-04-13 13:48:43 UTC 
well, those compat mappings are mostly for people with old xorg.conf files. But since noone complained about broken mapping, I am deleting this one.
Comment 8 Shai Berger 2011-04-13 14:03:39 UTC 
Thanks for the quick response and fix.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.