Bug 36354

Summary:	Add TpSavedMessage?
Product:	Telepathy	Reporter:	Guillaume Desmottes <guillaume.desmottes>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED MOVED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	enhancement
Priority:	medium	CC:	nicolas
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Guillaume Desmottes 2011-04-18 06:10:41 UTC

In https://bugs.freedesktop.org/show_bug.cgi?id=27175#c6 smcv wrote:
"""
...

TpMessage
  |
  \--- TpCMMessage (used by TpMessageMixin)
  \--- TpClientMessage (if needed, or just use the base class?)
         \--- TpSignalledMessage
              (or TpReceivedMessage, but it's used for MessageSent too)
              (has a TpContact for the sender if possible)
  \--- TpSavedMessage (the handle-less version, for the logger)

...
"""

We currently have TpMessage, TpCMMessage, TpClientMessage and TpSignalledMessage but not yet TpSavedMessage.

I was porting Empathy to TpTextChannel was thinking that TpSavedMessage could actually be pretty handy in order to rebase EmpathyMessage on top of TpMessage.

Comment 1 Guillaume Desmottes 2011-04-18 06:11:19 UTC

Nicolas: What do you think about this? Would take make sense for tp-logger's API to expose message as TpSavedMessage?

Comment 2 Nicolas Dufresne 2011-04-18 06:25:51 UTC

(In reply to comment #1)
> Nicolas: What do you think about this? Would take make sense for tp-logger's
> API to expose message as TpSavedMessage?

This would help to address bug 27174 (Make it possible to log composite messages). But it cannot replace the TplTextEvent as it cannot have TplEvent as base class. Maybe that would be provide by TplTextEvent in parallel with the simple _get_text() method ? Base on this, the only remaining utility is to give the logger the ability to create TpMessage (which is not easy atm).

Comment 3 GitLab Migration User 2019-12-03 20:38:13 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-glib/issues/64.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.