Bug 36361

There is just a missing comma at line ~ 5905 (device.c)

static const gchar *well_known_filesystems[] =
{
"btrfs",
"ext2",
"ext3",
"ext4",
"udf",
"iso9660",
"xfs",
"jfs",
"nilfs",
"reiserfs",
"reiser4",
"msdos",
"umsdos",
"vfat",
"exfat" <---- Missing comma
"ntfs",
NULL,
};

Fixed

 http://cgit.freedesktop.org/udisks/commit/?id=75b6187f77ca95ce435dd78f2ecb244af55e7faf

Sorry for the lag.

You fixed the comment#2 but does that really fix the real bug? With the comma fix applied I can't still mount my ntfs partitions unless I add ntfs-3g to the well known filesystem list.

(In reply to comment #3)
> You fixed the comment#2 but does that really fix the real bug? With the comma
> fix applied I can't still mount my ntfs partitions unless I add ntfs-3g to the
> well known filesystem list.

Indeed, see:

http://bugs.gentoo.org/show_bug.cgi?id=353343#c16

Reopening since this does fix the missing comma in fs list, but doesn't fix the original problem of missing entry for "ntfs-3g" by default

Development focus has been on udisks 2.0 for a while which is a completely different codebase so closing WORKSFORME. Please reopen if it doesn't work for you in udisks 2.0. Thanks.

Yeah, I'm still applying this in Gentoo's package for ntfs-3g:

$ cat files/udisks-2.x-ntfs-3g.patch 
--- src/udiskslinuxfilesystem.c
+++ src/udiskslinuxfilesystem.c
@@ -164,6 +164,7 @@
   "vfat",
   "exfat",
   "ntfs",
+  "ntfs-3g",
   NULL,
 };

But I'm not reopening this bug because I think this patch might be redudant by the udev rules file we install:

$ cat files/99-ntfs3g.rules 
ENV{ID_FS_TYPE}=="ntfs", ENV{ID_FS_TYPE}="ntfs-3g"

I'll report back if I find the patch still required. Thanks for now.

(In reply to comment #6)
> $ cat files/99-ntfs3g.rules 
> ENV{ID_FS_TYPE}=="ntfs", ENV{ID_FS_TYPE}="ntfs-3g"

Ugh, please dont do this, it is completely wrong. Here's why: ID_FS_TYPE is intended for the filesystem _type_ and ntfs-3g is not a filesystem type - it's an identifier for a particular driver for the NTFS filesystem. By subtly changing ID_FS_TYPE this way you are breaking code (such as GNOME Disks) that special cases devices with a NTFS filesystem on it. Please don't do things like this.

But thanks for the heads-up - until you stop doing things like this, I will not look at Gentoo bugs involving NTFS - less work for me, I guess ;-)