Bug 36627

Summary: _tpl_log_store_sqlite_get_pending_messages: Error preparing SQL for pending messages list: near "DSC": syntax error
Product: Telepathy Reporter: Guillaume Desmottes <guillaume.desmottes>
Component: loggerAssignee: Nicolas Dufresne <nicolas>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium CC: nicolas
Version: unspecifiedKeywords: patch
Hardware: Other   
OS: All   
URL: http://cgit.collabora.co.uk/git/user/nicolas/telepathy-logger.git/log/?h=trivia
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 36259    

Description Guillaume Desmottes 2011-04-27 02:33:35 UTC
I get this when trying to open a chat with any contact.

telepathy-logger:19433): tp-logger-DEBUG: main: Initialising TPL Channel Factory
(telepathy-logger:19433): tp-logger-DEBUG: main: - TplTextChannel registered.
(telepathy-logger:19433): tp-logger-DEBUG: main: - TplStreamedMediaChannel registered.
(telepathy-logger:19433): tp-logger-DEBUG: main: - TplCallChannel registered.
(telepathy-logger:19433): tp-logger-DEBUG: tpl_log_manager_init: Initialising the Log Manager
[New Thread 0x7ffff4358700 (LWP 19434)]
(telepathy-logger:19433): tp-logger-DEBUG: _tpl_log_manager_register_log_store: LogStore name=TpLogger registered
(telepathy-logger:19433): tp-logger-DEBUG: _tpl_log_manager_register_log_store: LogStore name=Empathy registered
(telepathy-logger:19433): tp-logger-DEBUG: _tpl_log_manager_register_log_store: LogStore name=Pidgin registered
(telepathy-logger:19433): tp-logger-DEBUG: _tpl_log_store_sqlite_init: cache file is '/home/dev/.cache/telepathy/logger/sqlite-data'
[New Thread 0x7ffff3b57700 (LWP 19435)]
(telepathy-logger:19433): tp-logger-DEBUG: purge_pending_messages: Purging entries older than 2011-04-27 08:31:54 (3600 seconds ago)
(telepathy-logger:19433): tp-logger-DEBUG: _tpl_log_manager_register_log_store: LogStore name=Sqlite registered
(telepathy-logger:19433): tp-logger-DEBUG: tpl_log_manager_init: Log Manager initialised
(telepathy-logger:19433): tp-logger-DEBUG: main: Registering channel factory into TplObserver
(telepathy-logger:19433): tp-logger-DEBUG: main: TPL Observer registered to: org.freedesktop.Telepathy.Client.Logger
(telepathy-logger:19433): tp-logger-DEBUG: telepathy_logger_dbus_init: Initializing TPL DBus service
[New Thread 0x7ffff28c5700 (LWP 19436)]
(telepathy-logger:19433): tp-logger-DEBUG: telepathy_logger_dbus_init: TPL DBus service registered to: org.freedesktop.Telepathy.Logger

(telepathy-logger:19433): tp-logger-DEBUG: tpl_observer_observe_channels:  gabble/jabber/cassidy_2dtest1_40jabber_2ebelnet_2ebe_2fceb47283/ImChannel2: Starting preparation for TplChannel instance 0x6b4000
(telepathy-logger:19433): tp-logger-DEBUG: tpl_entity_new: Self id: cassidy-test1@jabber.belnet.be, tok: 04f012ec9803cab7342b342289f69afde14469e6
(telepathy-logger:19433): tp-logger-DEBUG: tpl_entity_new: Contact id: cassidy@jabber.belnet.be, tok: 0a4bdebead4a6328ed44bcae5d619325bca5c7fa
(telepathy-logger:19433): tp-logger-DEBUG: _tpl_log_store_sqlite_get_pending_messages: Listing pending messages for channel gabble/jabber/cassidy_2dtest1_40jabber_2ebelnet_2ebe_2fceb47283/ImChannel2

tp-logger-CRITICAL **: _tpl_log_store_sqlite_get_pending_messages: Error preparing SQL for pending messages list: near "DSC": syntax error
aborting...

Program received signal SIGTRAP, Trace/breakpoint trap.
0x00007ffff6665688 in g_logv (log_domain=0x7ffff7bcdfa0 "tp-logger", log_level=G_LOG_LEVEL_CRITICAL, format=0x7ffff7bd3183 "%s", args1=0x7fffffffded0)
    at gmessages.c:553
warning: Source file is more recent than executable.
553			G_BREAKPOINT ();
(gdb) 
(gdb) 
(gdb) 
(gdb) bt
#0  0x00007ffff6665688 in g_logv (log_domain=0x7ffff7bcdfa0 "tp-logger", log_level=G_LOG_LEVEL_CRITICAL, format=0x7ffff7bd3183 "%s", 
    args1=0x7fffffffded0) at gmessages.c:553
#1  0x00007ffff66657f2 in g_log (log_domain=0x7ffff7bcdfa0 "tp-logger", log_level=G_LOG_LEVEL_CRITICAL, format=0x7ffff7bd3183 "%s") at gmessages.c:577
#2  0x00007ffff7bb9b93 in _tpl_critical (flag=TPL_DEBUG_LOG_STORE, format=<value optimized out>) at debug.c:123
#3  0x00007ffff7bc2aa0 in _tpl_log_store_sqlite_get_pending_messages (self=0x60f8d0, channel=0x6b4000, error=0x7fffffffe128) at log-store-sqlite.c:700
#4  0x00007ffff7bc7bf0 in pendingproc_store_pending_messages (ctx=0x686cc0, user_data=<value optimized out>) at text-channel.c:565
#5  0x00007ffff7bb6021 in _tpl_action_chain_continue (self=0x686cc0) at action-chain.c:117
#6  0x00007ffff5ccfc82 in contacts_context_continue (c=0x617330) at contact.c:1783
#7  0x00007ffff5cd266c in contacts_got_attributes (connection=0x6ab010, attributes=0x6a9770, error=<value optimized out>, user_data=0x617330, 
    weak_object=<value optimized out>) at contact.c:3740
#8  0x00007ffff5ca6ea8 in _tp_cli_connection_interface_contacts_invoke_callback_get_contact_attributes (self=0x6ab010, error=0x0, args=0x69fcc0, 
    generic_callback=0x7ffff5cd2230 <contacts_got_attributes>, user_data=<value optimized out>, weak_object=<value optimized out>)
    at _gen/tp-cli-connection-body.h:12181
#9  0x00007ffff5d15cf0 in tp_proxy_pending_call_idle_invoke (p=0x68ae40) at proxy-methods.c:153
#10 0x00007ffff665df8e in g_idle_dispatch (source=0x6a7100, callback=0x7ffff5d15c80 <tp_proxy_pending_call_idle_invoke>, user_data=0x68ae40)
    at gmain.c:4536
#11 0x00007ffff665a12c in g_main_dispatch (context=0x6154d0) at gmain.c:2440
#12 0x00007ffff665b6bc in g_main_context_dispatch (context=0x6154d0) at gmain.c:3013
#13 0x00007ffff665bb82 in g_main_context_iterate (context=0x6154d0, block=1, dispatch=1, self=0x604010) at gmain.c:3091
#14 0x00007ffff665c319 in g_main_loop_run (loop=0x66a840) at gmain.c:3299
#15 0x00000000004019fb in main (argc=<value optimized out>, argv=<value optimized out>) at telepathy-logger.c:204
Comment 1 Nicolas Dufresne 2011-04-27 08:10:24 UTC
Yeah, my bad, I don't handle the empty list, will fix soon, thanks for reporting.
Comment 2 Nicolas Dufresne 2011-04-29 16:21:29 UTC
Oops, that one was just a syntax error. Also order was wrong, we want ASC not DESC. I also fixed a missing trace, the first cached pending message to be removed was never traced. Might be causing 36259.

Two last commit of:
http://cgit.collabora.co.uk/git/user/nicolas/telepathy-logger.git/log/?h=trivia
Comment 3 Nicolas Dufresne 2011-05-04 09:39:14 UTC
Reviewed by David and pushed, should be in 0.2.9.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.