Bug 3664

Summary:	More Xnest modifier state confusion
Product:	xorg	Reporter:	Mark McLoughlin <mark>
Component:	Server/DDX/Xnest	Assignee:	Xorg Project Team <xorg-team>
Status:	RESOLVED FIXED	QA Contact:	Xorg Project Team <xorg-team>
Severity:	normal
Priority:	high	CC:	mallum, peter.hutterer
Version:	git
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Mark McLoughlin 2005-06-30 06:07:10 UTC

Further Xnest modifier state confusion which the fix in bug #3030 missed:

  1) Alt-Tab from Xnest window to another window
  2) Xnest never sees the Alt KeyRelease, thinks Alt is pressed
  3) Focus the Xnest window with the pointer
  4) Xnest doesn't correct the modifier state until you press a key

Obvious fix is to correct the modifier state using the modifier state in the
ButtonPress event in the same way we're doing it with KeyPress events.

Attached patch also masks out the button states as an optimisation, since we're
only interested in the modifier state.

Comment 1 Mark McLoughlin 2005-06-30 06:08:03 UTC

Created attachment 2996 [details] [review]
ok, fix the matrix transpose first

Comment 2 Adam Jackson 2005-07-02 10:03:18 UTC

applied, thanks!

mark, this is like the seventh xnest fix i've applied from you.  if you'd like
cvs access to speed the process along we'd be happy to hook you up.

Comment 3 Mark McLoughlin 2005-07-11 22:21:07 UTC

Nominating for the 6.8.x branch.

If the fix in bug #3030 (attachment #2897 [details] [review]) gets applied, it makes sense to apply
this trivial addition too.

Comment 4 Mark McLoughlin 2005-10-16 23:13:26 UTC

It looks like all the attachment links got screwed up (same thing happened in
bug #3030).

Here's the real patch which went into HEAD:

   http://www.gnome.org/~markmc/code/xnest-update-modifier-state2.patch

Comment 5 Daniel Stone 2007-02-27 01:27:15 UTC

Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.

Comment 6 Peter Hutterer 2009-09-07 19:17:05 UTC

Fixed again with 5904ef2ccd6056b187ca76f104c21e2d686bfc1d xnest: restore xnestUpdateModifierState

Seems to work for 1.7

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.