Bug 36877

Summary:	Comments are not displayed upon saving and reopening RTF, are lost on re-saving
Product:	LibreOffice	Reporter:	jjmcgaffey <jjmcgaffey>
Component:	Writer	Assignee:	Miklos Vajna <vmiklos>
Status:	CLOSED FIXED	QA Contact:
Severity:	major
Priority:	medium	CC:	cs0364869, jbfaure, LibreOffice
Version:	3.3.2 release
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	File with comment File edited & saved, no comment

Description jjmcgaffey 2011-05-05 12:57:38 UTC

Created attachment 46374 [details]
File with comment

Related to bug 33463, but that applies to .docx and this to RTF.

I had an RTF file that I was redlining. I opened the file, made some comments (and changes), and saved it in .rtf (there was no warning about losing formatting). When I reopened, the changes were there but there were no comments visible. I ran some tests; the comments are, in fact, saved in .rtf format (when looking at the raw file, the /annotation keyword is present with my name and the text of the comment(s)), but when the file is reopened in Writer, the comments are not displayed. Then when the file is edited and re-saved, the comments are gone.

Two files attached: an RTF file with a comment, and the same file (copied and saved with a new name) opened in Writer, edited and saved. Neither show any comments in Writer; the first has a comment in Word and the /annotation keyword in Notepad++.

Comment 1 jjmcgaffey 2011-05-05 12:58:18 UTC

Created attachment 46375 [details]
File edited & saved, no comment

Comment 2 Noel Power 2011-05-06 03:45:56 UTC

Miklos could you have a look please ( please reassign back to the list if not )

Comment 3 Miklos Vajna 2011-05-06 04:24:59 UTC

Noel, this is an import bug. I just verified that:

1) Creating a new doc with a comment in Word2007 -> save as rtf -> import in LO results in no comment, but 
2) The other way around works fine.

I have no idea right now how to fix it, but in case it's not urgent, I'm willing to fix it within the GSoC timeframe.

If it's more urgent, then let's assign it back to the list.

Thanks.

Comment 4 Rainer Bielefeld Retired 2011-06-11 23:57:38 UTC

I modified Status to Assigned due to facts.

Comment 5 Miklos Vajna 2011-07-25 12:44:24 UTC

This is fixed in my GSoC repo:

http://cgit.freedesktop.org/~vmiklos/lo-filters/commit/?id=2660469d1b63fdbd96e3971d066530cc4711a2eb

Note that only comment text is imported, the underlying dmapper does not support author names and timestamps yet, but it's on my TODO.

I'll merge that repo to master before 2011-08-15 and you'll have this feature if you enable experimental features. (Later hopefully it'll be the default, but there is no decision about that yet.)

Comment 6 Miklos Vajna 2011-07-25 15:58:31 UTC

Author names / dates are now also supported in the above mentioned repo.

Comment 7 vitriol 2011-09-27 14:51:32 UTC

*** Bug 41274 has been marked as a duplicate of this bug. ***

Comment 8 Jean-Baptiste Faure 2012-03-18 10:15:01 UTC

Fix confirmed in LO 3.5.1. Comments are visible in first attachment.
Closing. Thank you.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.