Bug 37106

Summary:	Unnecessarily hides GInterface vtables
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	mission-control	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	will
Version:	5.7	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://cgit.collabora.co.uk/git/user/smcv/telepathy-mission-control-smcv.git/log/?h=expose-ifaces
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:	32914
Bug Blocks:	27363

Description Simon McVittie 2011-05-11 03:37:43 UTC

+++ This bug was initially created as a clone of Bug #32914 +++

wjt wrote:
> But I can't chain up, because McpAccountStorageIface is hidden, and the vtable > is filled in using _implement_foo functions. This seems completely pointless to > me. The main rationale for this pattern in tp-glib's generated interfaces is to > avoid reorderings in the spec affecting ABI

It is indeed pointless: GObject upstream don't consider appending to a GInterface vtable struct (the ones that start with a GTypeInterface) to be an incompatible change.

wjt's branch fixes AccountStorage, a recently-merged branch fixes DispatchOperationPolicy, and the branch in the URL field here fixes the remaining implemented-by-plugins classes so far, namely RequestPolicy and DBusAcl. It also improves some documentation.

Comment 1 Vivek Dasmohapatra 2011-05-11 08:07:15 UTC

Released in 5.7.11

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.