Bug 37115

Summary:	Make the heartbeat synchronise with the other applications
Product:	Wocky	Reporter:	Marco Barisione <marco.barisione>
Component:	General	Assignee:	Marco Barisione <marco.barisione>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	smcv
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://cgit.collabora.co.uk/git/user/bari/wocky.git/log/
Whiteboard:	review+
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	37354

Description Marco Barisione 2011-05-11 08:22:37 UTC

MeeGo has a new version of iphb that allows a different kind of interval to be passed to iphb_wait().
Currently we pass the minimum and maximum number of seconds we want to be waken up from now. With iphb 0.61.29 we can pass the same interval both as minimum and maximum value and that means we want to be waken up every x seconds (so the first time it could be much shorter).
If we use this feature with a set of recommended intervals (used also by other applications) we can get a better power usage as all the application will be waken up at the same time.

Comment 1 Marco Barisione 2011-05-11 10:33:37 UTC

http://cgit.collabora.co.uk/git/user/bari/wocky.git/log/ contains the patch to fix this.
Note that iphb didn't bump their API version number when adding those defines, so we cannot ad a configure check. I complained about it and hopefully it will be fixed soon, but if you could review this in the meantime it could be useful :)

Comment 2 Simon McVittie 2011-05-12 01:56:13 UTC

Looks good to me.

Comment 3 Simon McVittie 2011-05-12 02:00:41 UTC

You might be able to configure-check it via:

    AC_CHECK_DECL([IPHB_GS_WAIT_30_MIN], [$LIBIPHB_CFLAGS])

or some such?

Comment 4 Simon McVittie 2011-05-12 02:02:02 UTC

(In reply to comment #3)
>     AC_CHECK_DECL([IPHB_GS_WAIT_30_MIN], [$LIBIPHB_CFLAGS])

er, AC_CHECK_DECL([IPHB_GS_WAIT_30_MIN], [have_new_iphb=yes], [have_new_iphb=no], [$LIBIPHB_CFLAGS])

Comment 5 Marco Barisione 2011-05-12 09:37:00 UTC

(In reply to comment #4)
> (In reply to comment #3)
> >     AC_CHECK_DECL([IPHB_GS_WAIT_30_MIN], [$LIBIPHB_CFLAGS])
> 
> er, AC_CHECK_DECL([IPHB_GS_WAIT_30_MIN], [have_new_iphb=yes],
> [have_new_iphb=no], [$LIBIPHB_CFLAGS])

They will fix the .pc file.

But it seems they want to change their defines now, so this will have to wait...

Comment 6 Marco Barisione 2011-05-16 08:36:23 UTC

Can you please take a look again? I added a “configure: depend on libiphb >= 0.61.31” patch and modified “Heartbeat: synchronise the wakeups with other applications” with the updated intervals.

Comment 7 Marco Barisione 2011-05-16 08:47:18 UTC

Pushed to master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.