Summary: | testtool complains Unknown Command for legal script when running bas. | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Yifan Jiang <yfjiang> |
Component: | BASIC | Assignee: | Noel Power <nopower> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | medium | CC: | matuaki |
Version: | 3.4.0 Beta5 | Keywords: | regression |
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | patch for 3.4 |
Description
Yifan Jiang
2011-05-13 01:00:30 UTC
Hi Noel, since this is constantly reproducible in a clean environment. I opened the bug for your review. Thanks! P.S It might also influence other 'internal command' of testautomation thus make the automation test not runnable. Hmmm, I just left a comment on the dev mailing list about the smoketests failing during make check when building from master ? Something to do with failed assertions in officeconnection.cxx - linked ? Alex Created attachment 51392 [details] [review] patch for 3.4 fixes ( or appears to ) fix the testtool problems on 3.4 I tested with f_topten.bas ( because it is a short test ) Note: I started running the one mentioned above but after some time it was clear this test was going to take too long so I tried f_topten.bas instead. The root cause of the problems was cws changehid which replaced numerical hid's by strings. Additionally the class smarthid was removed. The patch imo is not ideal, . It appears that there are still hid(s) that are stringified numbers ( or at least that's what the testtool code expects ) and now the testtool code goes to extra trouble to convert between strings/numbers. I would guess this makes the testtool slower. This should be changed on master, for 3.4 I think a "just get it working" approach might be the best fixed on 3.4 branch |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.