Summary: | scanpci -v dumps core on Acer Ferrari 4000 laptop | ||
---|---|---|---|
Product: | xorg | Reporter: | Alan Coopersmith <alan.coopersmith> |
Component: | Lib/pciaccess | Assignee: | Alan Coopersmith <alan.coopersmith> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | high | ||
Version: | 6.8.2 | ||
Hardware: | x86 (IA32) | ||
OS: | Solaris | ||
URL: | http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6295276 | ||
Whiteboard: | |||
i915 platform: | i915 features: |
Description
Alan Coopersmith
2005-07-13 04:05:55 UTC
Looks like if the subsys vendor/device id's were NOVENDOR & NODEVICE (0xFFFF) scanpci never set the pointers to the names to print, but the printing code didn't check for those values and passed whatever pointers happened to be on the stack. I've both initialized the pointers and checked for those values before printing, and the reporter verified the test binary I generated no longer crashed. Patch to follow momentarily. Created attachment 3074 [details] [review] Here's the patch used in OpenBSD Fix committed to CVS head for 6.9 release: CVSROOT: /cvs/xorg Module name: xc Changes by: alanc@gabe.freedesktop.org 05/07/12 11:16:03 Log message: 2005-07-12 Alan Coopersmith <alan.coopersmith@sun.com> * programs/Xserver/hw/xfree86/etc/scanpci.c: Fix scanpci -v core dump when subsys vendor/device id's are NOVENDOR & NODEVICE. Bug #3763 <https://bugs.freedesktop.org/show_bug.cgi?id=3763> Patch #3074 <https://bugs.freedesktop.org/attachment.cgi?id=3074> Modified files: ./: ChangeLog xc/programs/Xserver/hw/xfree86/etc/: scanpci.c Revision Changes Path 1.1109 +8 -0 xc/ChangeLog 1.7 +3 -1 xc/programs/Xserver/hw/xfree86/etc/scanpci.c |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.