Bug 3769

Summary: MAXFORMATS needs to die
Product: xorg Reporter: Stuart Anderson <anderson>
Component: Server/DDX/XorgAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED MOVED QA Contact: Xorg Project Team <xorg-team>
Severity: major    
Priority: high CC: mlists
Version: 6.9.0   
Hardware: Other   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Stuart Anderson 2005-07-14 08:30:23 UTC
The change for bug #2791 to add support for 12 & 30 bit depths causes more 
than MAXFORMATS depths to be created when RENDER is enabled. That overflows 
GCperDepth in the Screen structure and causes a crash. 
 
 screen #0: 
   dimensions:    1024x768 pixels (260x195 millimeters) 
   resolution:    100x100 dots per inch 
   depths (9):    1, 4, 8, 12, 16, 24, 30, 32, 8 
 
an additional questions, is why is the screen's depth listed twice? 
 
Is it safe to just increase MAXFORMATS? or is there a more appropriate 
solution?
Comment 1 Adam Jackson 2005-11-19 04:01:34 UTC
12bpp and 30bpp are disabled in HEAD now, so this isn't an 7.0 issue.
Comment 2 Adam Jackson 2006-04-25 05:40:51 UTC
(In reply to comment #1)
> 12bpp and 30bpp are disabled in HEAD now, so this isn't an 7.0 issue.

Likewise for 7.1, moving out to 7.2.
Comment 3 Daniel Stone 2006-11-04 09:53:27 UTC
... and for 7.2 ...
Comment 4 Daniel Stone 2007-02-27 01:27:18 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 5 Adam Jackson 2007-11-16 17:18:48 UTC
I'm working on removing MAXFORMATS from the ABI structures.

Updating summary to reflect reality.
Comment 6 GitLab Migration User 2018-12-13 18:27:57 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/xserver/issues/135.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.