| Summary: | 'make check' should skip X-requiring tests if X not available (currently fails) | ||
|---|---|---|---|
| Product: | cairo | Reporter: | Luis Villa <luis.villa> |
| Component: | xlib backend | Assignee: | Carl Worth <cworth> |
| Status: | RESOLVED FIXED | QA Contact: | cairo-bugs mailing list <cairo-bugs> |
| Severity: | normal | ||
| Priority: | high | ||
| Version: | 0.9.3 | ||
| Hardware: | x86 (IA32) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Luis Villa
2005-07-15 02:07:37 UTC
I've fixed this so that backends that are untestable (for whatever reason) print a result of UNTESTED rather than FAIL. Then, the overall test result is SUCCESS if and only if there is at least one backend that is tested and all tested backends return SUCCESS. This should do the trick for the compiled-with-xlib-support-but-testing- without-an-X-server case. One downside is that "make check" will run a bit slower since it will wait for XOpenDisplay to timeout on each test. Hopefully that's not a critical concern on a tinderbox machine. Otherwise, we could reduce the delay to a single timeout if we ignored the builtin "make check" loop and wrote our own program to loop over all tests. (I've been thinking of doing this independently to easily allow all tests to be run under valgrind.) Thanks a bunch, Carl. At least here, the timeout seems ~0 anyway- probably not worth rewriting. Move bugs against "cvs" version to "0.9.3" so we can remove the "cvs" version. This is still a bug in release 1.14.2, at least on Mac OS X. $ ./configure --disable-xlib --disable-ft --enable-png --disable-dependency-tracking $ make $ make check <snip> Making check in . make any2ppm make[5]: `any2ppm' is up to date. make check-TESTS <snip> LOTS OF "X11 quit unexpectedly." dialogs pop up here. And, yes, the tests take FOREVER. <snip> FAIL: cairo-test-suite make all-recursive Making all in pdiff make all-am make[10]: Nothing to be done for `all-am'. Making all in . make[9]: Nothing to be done for `all-am'. ============================================================================ Testsuite summary for cairo 1.14.2 ============================================================================ # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 ============================================================================ See test/test-suite.log Please report to http://bugs.freedesktop.org/enter_bug.cgi?product=cairo ============================================================================ make[6]: *** [test-suite.log] Error 1 make[5]: *** [check-TESTS] Error 2 make[4]: *** [check-am] Error 2 make[3]: *** [check-recursive] Error 1 make[2]: *** [check] Error 2 make[1]: *** [check-recursive] Error 1 make: *** [check] Error 2 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.