| Summary: | [Patch] new Bengali Keyboard Layouts | ||
|---|---|---|---|
| Product: | xkeyboard-config | Reporter: | Bryce Harrington <bryce> |
| Component: | General | Assignee: | xkb |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Patch to add four keyboard layouts
Remaining evdev.xml.in changes Added four new Bengali Keyboard Layout |
||
|
Description
Bryce Harrington
2011-06-06 15:49:07 UTC
Created attachment 47625 [details] [review] Remaining evdev.xml.in changes The original patch also had a change to evdev.xml.in which I am not seeing in the current xkeyboard-config git tree. Not sure if that was dropped or just moved; I'll attach that chunk here just in case it's still needed. Several things: 1. Are you sure all those variants are needed in the core set? Would it make sense to put (some of) them into base.extras.xml.in? Are they all used by many people? 2. The descriptions does not follow the existing conventions. Could you please fix? 3. Do not bother about evdev.xml.in - it is copied from base.xml.in Created attachment 47709 [details] [review] Added four new Bengali Keyboard Layout Respected Sir, I made all changes that you are told earlier. Please review the patch. 1. All the variants are needed in the core set, because all keyboards are popular layout. 2. descriptions tag fix 3. remove evdev.xml.in Thanks, that's great. I took freedom to drop the variantsMapping part - there is no compatibility requirement in this case. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.