Bug 38126

Summary:	Call: A per-codec "config param changed" boolean
Product:	Telepathy	Reporter:	Olivier Crête <olivier.crete>
Component:	tp-spec	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	david.laban
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:	Call
i915 platform:		i915 features:

Description Olivier Crête 2011-06-09 15:55:52 UTC

In Farsight2, I know if a codec needs to be re-sent or not. This information is lost .. and gabble needs to do a new diff of the codecs, but it may still send useless data.

I'd like to be able to annotate each codec so that gabble can know which ones to send, but something rakia (SIP) would still have the whole list that it can send as-is.

This applies to both Content.I.Media.UpdateLocalMediaDescription() and MediaDescription.Accept()

Comment 1 David Laban 2011-06-10 14:44:02 UTC

This is something that you almost solved with the requires negotiation flag, but it felt a bit like a halfway fix. Now that you've had a chance to think about it more in practice, can you give me a better API and an example of how gabble would signal it?

Comment 2 David Laban 2011-06-30 12:44:34 UTC

I have sketched something up at:

http://cgit.collabora.com/git/user/alsuren/telepathy-spec.git/log/?h=per-codec-38126

Can you remind me of the use-case where doing a diff will produce false-positives that can be suppressed by this flag? (I've suddenly gone back to being unconvinced that there's any point in this flag. That's what I get for procrastinating writing it up).

Also, note that I almost called it FurtherNegotiationRequired, but I realised that setting it would not necessarily produce a new MediaDescriptionOffer in the same way that FurtherNegotiationRequired does, so I just called it "Updated".

ocrete: Also, can you quickly grep through the docs for FurtherNegotiationRequired, and make sure that its semantics make sense to you?

Comment 3 Olivier Crête 2011-06-30 14:03:05 UTC

Offer:
ILBC ptime=30
Answer:
ILBC ptime=20
causes a change to
ILBC ptime=30
because it uses the max of 20 and 30..

There is no way the CM can know that, but farsight2 has a list of all the codecs and how to negotiate each param. That's why I must tell the CM.

Comment 4 David Laban 2011-06-30 15:12:25 UTC

Thanks. Reworded my commit to refer to ptime as an example.

I think that http://cgit.collabora.com/git/user/alsuren/telepathy-spec.git/log/?h=per-codec-38126 is ready for review.

Comment 5 Olivier Crête 2011-07-05 12:28:00 UTC

++

Comment 6 David Laban 2011-07-19 13:37:30 UTC

merged to master

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.