Bug 38148

Summary: cairo build on interix
Product: cairo Reporter: Markus Duft <mduft>
Component: generalAssignee: Carl Worth <cworth>
Status: RESOLVED FIXED QA Contact: cairo-bugs mailing list <cairo-bugs>
Severity: normal    
Priority: medium    
Version: 1.10.2   
Hardware: Other   
OS: Interix   
Whiteboard:
i915 platform: i915 features:
Attachments: check for lround() presence
fix pkgconfig related things for interix.

Description Markus Duft 2011-06-10 04:29:53 UTC
Created attachment 47804 [details] [review]
check for lround() presence

i'd have 2 patches for the cairo library to build and work on interix. could you please review and comment on them? thanks.
Comment 1 Markus Duft 2011-06-10 04:30:36 UTC
Created attachment 47805 [details] [review]
fix pkgconfig related things for interix.
Comment 2 Benjamin Otte 2011-06-10 05:55:16 UTC
That Requires vs Require.private thing would be way easier to fix in pkg-config (by making pkg-config treat Requires the same as Requires.private on Interix). Because every package that uses private requires will have that problem, and the number of those packages is growing all the time (It's >80 on my system, and >90 using Libs.private).
Also, I'm not a fan of keeping a list of weird linkers in every configure.ac.

Fwiw, something like alias pkg-config=pkg-config --static should be a quickfix for the problem.

(And no idea about the lround thing).
Comment 3 Markus Duft 2011-06-15 01:59:21 UTC
mhm. i'm ok with the pkgconfig thing not beeing accepted :)

however, what about the lround thing? gentoo's x11 herd is blocking me committing the patch to our tree until you guys commit it, or at least say it looks ok... opinions?
Comment 4 Andrea Canciani 2011-06-20 05:05:52 UTC
(In reply to comment #3)
> mhm. i'm ok with the pkgconfig thing not beeing accepted :)
> 
> however, what about the lround thing? gentoo's x11 herd is blocking me
> committing the patch to our tree until you guys commit it, or at least say it
> looks ok... opinions?

In cairo master lround() is not used at all since commit
95f6f7a174ca096a3d3dbe84ff220d166d1e2baa, which patches the code in
a very similar way to what you're doing, so I guess it looks ok.

I like the type-checking provided by the commit in master and I would
suggest you to use that patch, as it will probably be easier for yuo to merge
upon version upgrades.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.