Bug 38345

Summary: xprop -set with 'u8' format yields "xprop: error: Bad format: u8."
Product: xorg Reporter: Shlomi Fish <shlomif>
Component: App/xpropAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: major    
Priority: medium CC: jeremyhu
Version: 7.6 (2010.12)   
Hardware: All   
OS: All   
Whiteboard: 2011BRB_Reviewed
i915 platform: i915 features:

Description Shlomi Fish 2011-06-15 05:51:47 UTC
Observe:

<<<
shlomif:~$ xprop -root -f '_NET_DESKTOP_NAMES' u8 -set '_NET_DESKTOP_NAMES' '"foo"' 
xprop: error: Bad format: u8.
>>>

According to the man page, it should work. Apparently, there's a 'u' missing from the «switch (format_char) {» in Set_Property().

Please fix it.

Regards,

-- Shlomi Fish
Comment 1 Shlomi Fish 2011-06-15 06:05:54 UTC
(In reply to comment #0)
> Observe:
> 
> <<<
> shlomif:~$ xprop -root -f '_NET_DESKTOP_NAMES' u8 -set '_NET_DESKTOP_NAMES'
> '"foo"' 
> xprop: error: Bad format: u8.
> >>>
> 
> According to the man page, it should work. Apparently, there's a 'u' missing
> from the «switch (format_char) {» in Set_Property().
> 
> Please fix it.
> 
> Regards,
> 
> -- Shlomi Fish

I'm sorry, what I tried is:

<<<
$ xprop -root -f '_NET_DESKTOP_NAMES' 8u -set '_NET_DESKTOP_NAMES' '"foo"' 
xprop: error: bad format character: u
>>>
Comment 2 Jeremy Huddleston Sequoia 2011-10-06 09:43:40 UTC
You seem to know what the fix is.  Please email a patch to xorg-devel for 
review.
Comment 3 Shlomi Fish 2011-10-06 11:31:11 UTC
Hi,

(In reply to comment #2)
> You seem to know what the fix is.  Please email a patch to xorg-devel for 
> review.

well, I believe I tried fixing the problem myself, but it didn't work too well, and I don't know if my fix is the proper way to do it. I also ended up doing what I had in mind in a different way, without using xprop. So I guess I won't be able to submit a patch.
Comment 4 Alkis Georgopoulos 2015-06-09 09:33:31 UTC
This bug was fixed in http://cgit.freedesktop.org/xorg/app/xprop/commit/?id=0d069c0edae83f70ac10fab1a3c04d8197e277c4

And since this bug report came up first in google, I'm mentioning it so that it's easier for future readers to locate that commit...
Comment 5 Shlomi Fish 2015-06-09 10:03:16 UTC
(In reply to Alkis Georgopoulos from comment #4)
> This bug was fixed in
> http://cgit.freedesktop.org/xorg/app/xprop/commit/
> ?id=0d069c0edae83f70ac10fab1a3c04d8197e277c4
> 
> And since this bug report came up first in google, I'm mentioning it so that
> it's easier for future readers to locate that commit...

Thanks for fixing it!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.