Bug 38649

Summary: piglit fbo-copyteximage regression
Product: Mesa Reporter: Vinson Lee <vlee>
Component: Mesa coreAssignee: Stephane Marchesin <marchesin>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: medium CC: brianp
Version: git   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
Attachments: fbo-copyteximage.png

Description Vinson Lee 2011-06-24 10:50:56 UTC
Created attachment 48385 [details]
fbo-copyteximage.png

mesa: d91dc4a356e5509116572770b89d0a7520a55bfc (master)

Run piglit fbo-copyteximage on softpipe or llvmpipe. The test now fails but previously passed.

$ ./bin/fbo-copyteximage
Probe at (73,73)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (200,73)
  Expected: 0.000000 1.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (73,200)
  Expected: 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Probe at (200,200)
  Expected: 1.000000 1.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
Comment 1 Vinson Lee 2011-06-24 11:02:55 UTC
1a339b6c71ebab6e1a64f05b2e133022d3bbcd15 is the first bad commit
commit 1a339b6c71ebab6e1a64f05b2e133022d3bbcd15
Author: St├ęphane Marchesin <marcheu@chromium.org>
Date:   Wed Jun 22 17:02:21 2011 -0700

    st/mesa: prefer native texture formats when possible.
    
    If possible, we want to match the hardware format to what the app uses. By
    doing so, we avoid the need for pixel conversions and therefore greatly speed
    up texture uploads.

:040000 040000 6f6f68f2559303df0e7041dc1190cd1587557753 a353f28889dc64549acc3933edc12082e5d21a5a M	src
bisect run success
Comment 2 Brian Paul 2011-06-24 13:04:20 UTC
Fixed with commit 09e71cf7228232aa203915c9248c79cf26c5b917
Comment 3 Vinson Lee 2011-06-24 18:56:01 UTC
mesa: 7b44830ef40b6d4644c3f55189ed2457e6822428 (master)

Verified fixed.