Bug 38753

Summary: Strange drawing around models in r600g in SC2
Product: Mesa Reporter: Asbjørn Sannes <ace>
Component: Drivers/Gallium/r600Assignee: Default DRI bug account <dri-devel>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: brian.e.paul, sa
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: A white sphere is drawn around a model
Same screen after reverting commit 43bdabd47d98975b56a759954fb5f37d2942c101

Description Asbjørn Sannes 2011-06-28 10:00:46 UTC 
When playing a game of sc2 under wine, some models have a white sphere around them.

This started happening after commit:
commit 43bdabd47d98975b56a759954fb5f37d2942c101                                                                                                                                                                                  
Author: Brian Paul <brianp@vmware.com>                                                                                                                                                                                           
Date:   Wed May 18 16:19:06 2011 -0600                                                                                                                                                                                           
                                                                                                                                                                                                                                 
    mesa: fix vertex array enable checking in check_valid_to_render()                                                                                                                                                            
                                                                                                                                                                                                                                 
    In particular, this fixes the case where a vertex shader only uses                                                                                                                                                           
    generic vertex attributes (non-0th).  Before, we were no-op'ing the                                                                                                                                                          
    glDrawArrays/Elements().                                                                                                                                                                                                     
                                                                                                                                                                                                                                 
    This fixes the new piglit pos-array test.                                                                                                                                                                                    
                                                                                                                                                                                                                                 
    NOTE: This is a candidate for the 7.10 branch.                                                                                                                                                                               

I will attach two images, one where the commit is reverted.

My hardware is as follows:
ATI Technologies Inc RV770 [Radeon HD 4870]

Using r600g on gentoo ~amd64, with a 32bit chroot with r600g also.
Comment 1 Asbjørn Sannes 2011-06-28 10:03:37 UTC 
Created attachment 48521 [details]
A white sphere is drawn around a model
Comment 2 Asbjørn Sannes 2011-06-28 10:04:36 UTC 
Created attachment 48522 [details]
Same screen after reverting commit 43bdabd47d98975b56a759954fb5f37d2942c101
Comment 3 Asbjørn Sannes 2011-08-17 12:09:04 UTC 
It still works to revert that commit.
Comment 4 Asbjørn Sannes 2011-08-19 11:06:22 UTC 
If I disable UseGLSL in wine it also looks okay, not sure what it means. I guess it could be a problem in wine uncovered by the above commit or that it uncovered a bug elsewhere in mesa.
Comment 5 Brian Paul 2011-08-19 15:38:28 UTC 
I double-checked the patch in question and I think it's correct.

Do you think you could create a GL API trace of this game?  Then I could try to reproduce it here.

See https://github.com/apitrace/apitrace for info.
Comment 6 Asbjørn Sannes 2011-08-20 01:54:03 UTC 
Already did, but the trace becomes 1.2 gigabyte before I get to somewhere that displays the error. qapitrace crashes while loading the trace.
Comment 7 Asbjørn Sannes 2013-01-12 12:30:38 UTC 
For what it is worth, it seems to be working fine now. Think it was fixed within the last two months. If you like I could bisect to find out where it was fixed. Else we could just close this.
Comment 8 Marek Olšák 2014-04-13 11:50:27 UTC 
(In reply to comment #7)
> For what it is worth, it seems to be working fine now. Think it was fixed
> within the last two months. If you like I could bisect to find out where it
> was fixed. Else we could just close this.

Closing.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.