| Summary: | Make MAXSCREENS run-time configurable | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Kevin E. Martin <kem> | ||||
| Component: | Server/General | Assignee: | Xorg Project Team <xorg-team> | ||||
| Status: | RESOLVED MOVED | QA Contact: | Xorg Project Team <xorg-team> | ||||
| Severity: | enhancement | ||||||
| Priority: | high | CC: | faith, mlists | ||||
| Version: | git | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Attachments: |
|
||||||
Created attachment 3147 [details]
My C++ test application to demonstrate the bug
Note that this is the original patch that we created against XFree86. It
applied to X.Org X11R6.7 at the time, so it will need to be updated when we
decide to include it in the release.
Also note that this patch will break the internal server ABIs. patch lost in bugzilla disk death, please reattach Created attachment 5708 [details] [review] Original MAXSCREENS patch This is the original patch. It will need work to make it apply to the modular tree and to make sure there are no new references to MAXSCREENS. Note Rik Faith is the primary author of this patch. Sorry about the phenomenal bug spam, guys. Adding xorg-team@ to the QA contact so bugs don't get lost in future. Kevin E. Martin Do you still experience this issue with newer soft ? Please check the status of your issue. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
The goals of the patch are as follows: 1) Allow MAXSCREENS to be determined at run time instead of compile time (a new -maxscreens command line flag was added). 2) Make minimal source-code changes to the tree: a) The name "MAXSCREENS" was not changed -- this allowed all of the loops that reference MAXSCREENS to remain unchanged. b) MAXSCREENSALLOC is a convenience macro that allocates and zeros memory, allowing 1-line changes to allocate code (and another line to check that allocation succeeded). Memory is zero'd because many routines assume that the previous static allocations are zero'd. The macro is also safe to call multiple times since there are places in the code where the first use of a MAXSCREENS-sized array is difficult to determine (or non-deterministic). c) In some cases, the existing code zeros the memory. These calls are unchanged, but could be removed. Some of the changes could not be tested because we do not have the appropriate hardware available -- it would be possible to substitute MAXSCREENSDEFAULT for MAXSCREENS in these code paths (i.e., and leave them as compile-time configurable code paths): config/cf/iPAQH3600.cf config/cf/itsy.cf programs/Xserver/hw/darwin/quartz/fullscreen/fullscreen.c programs/Xserver/hw/kdrive/kxv.c programs/Xserver/hw/sun/sunInit.c programs/Xserver/hw/sunLynx/sunLyInit.c programs/Xserver/hw/xfree86/drivers/* [all the changes are similar] programs/Xserver/hw/xfree86/os-support/bsd/arm_video.c programs/Xserver/hw/xfree86/os-support/dgux/dgux_video.c programs/Xserver/hw/xwin/InitOutput.c