Bug 38777

Summary:

Oops in describe_obj() when reading i915_context_status on debugfs

Product:

DRI

Reporter:

Pavel Roskin <proski>

Component:

DRM/Intel

Assignee:

Ben Widawsky <ben>

Status:

CLOSED FIXED

QA Contact:

Severity:

major

Priority:

medium

CC:

jbarnes

Version:

unspecified

Hardware:

Other

OS:

Linux (All)

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
patch that makes describe_obj() tolerate NULL	none

Description Pavel Roskin 2011-06-29 08:12:30 UTC

Created attachment 48556 [details] [review]
patch that makes describe_obj() tolerate NULL

Linux 3.0-rc5 oopses when /sys/kernel/debug/dri/0/i915_context_status is accessed for reading.

It appears that both dev_priv->pwrctx and dev_priv->renderctx are NULL, and they are passed to describe_obj() as the second argument.

Either describe_obj() should be made tolerant to NULL, or i915_context_status() should check what it passes to describe_obj() and output something meaningful.

Comment 1 Ben Widawsky 2011-06-29 12:04:06 UTC

I think it's beneficial to make describe_obj still barf on NULL, as we never mean to call it with a NULL object.

https://patchwork.kernel.org/patch/930062/

Thanks for reporting it.

Comment 2 Ben Widawsky 2011-06-30 15:37:16 UTC

Will be released in 3.0.

dc501fbc4389f6c15a8da14684b5926e0d9553da

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.