| Summary: | Improve Up/Down movement in writer | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Björn Michaelsen <bjoern.michaelsen> |
| Component: | Writer | Assignee: | Juergen Funk <juergen.funk_ml> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | libreoffice |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | EasyHack DifficultyInteresting SkillCpp TopicUi target:4.4.0 | ||
| i915 platform: | i915 features: | ||
|
Description
Björn Michaelsen
2011-07-01 07:09:43 UTC
Is this just for normal text in writer? Why is this even an issue? I was under the impression that this was for special equation notation cursors, but It doesn't even look like there is a cursor that moves up and down when you are writing equations. The only SmCursor::Move method is in the starmath module, here: http://opengrok.libreoffice.org/xref/core/starmath/source/cursor.cxx#36 Deteted "Easyhack" from summary adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details Hello, I am starting work on this bug. I think the right behavior is the start postion. When move down i expect that the caret is on the same postion. But when a line is shorter then he jump to the end of this line (jump left). When the follow line is longer the position is where i started (jump right). But in this case the caret jump left and right, but i think the positon is importent point. That is the behavior of WORD, maybe i a little bit MS contaminated. Hi Michal Strnad, i would like do fix this bug look to my "Comment 6". Do you have a problem with that? Checkin in Master https://gerrit.libreoffice.org/#/c/11500/ My first checkin i hope it is okay. The main problem is after the cursor down get a event from i don't know but in the stack i see - swlo.dll!SwCrsrShell::UpdateCrsr . . - sfxlo.dll!SfxObjectShell::FlushDocInfo . . - swlo.dll!SfxStubSwViewStateStatusLine . . - sfxlo.dll!SfxBindings::LinkStubNextJob_Impl i am not sure is that needed to update the cursor, without this event my fix is not necessary? The next i have see is ActionPend() && BasicActionPend() when ActionPend = TRUE the BasicActionPend is TRUE too when ActionPend = FALSE the BasicActionPend is FALSE too The BasicActionPend is not needed!? The change in crstrvl.cxx is only for the consistency Hi Juergen, welcome to the LibreOffice community! We hope you enjoy your stay :-) I’m marking this bug “ASSIGNED”, and when your patch is accepted into the core repository, we can change the status to “FIXED”. Thanks for your contribution! Juergen Funk committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d58bea0ffa2a2fe79103ab7aa743aea63e27a0fd Fix fdo#38884 Improve Up/Down movement in writer The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Juergen Funk committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e98e9fda34736731e4c539b1799abb4257219988 fdo#38884 Fix setting X position with dbgutil enabled The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.