Bug 38974

Summary: goo/gtypes.h must #include <stdbool.h>
Product: poppler Reporter: Adrian Bunk <bunk>
Component: generalAssignee: poppler-bugs <poppler-bugs>
Status: RESOLVED NOTABUG QA Contact:
Severity: normal    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: patch

Description Adrian Bunk 2011-07-05 05:26:19 UTC
Created attachment 48769 [details] [review]
patch

Since commit ae79fc50 (Make GBool a bool instead of an int) this
header uses "bool".

This patch fixes the following build error I saw with xpdf in Debian:

<--  snip  -->

...
cc -g -O2 -march=core2 -I/usr/include/poppler -I/usr/include/poppler/goo -I/usr/include/poppler/splash -Wno-write-strings -DHAVE_DIRENT_H  -c -o build/parseargs.o build/parseargs.c
In file included from build/parseargs.h:16:0,
                 from build/parseargs.c:14:
/usr/include/poppler/goo/gtypes.h:31:1: error: unknown type name ‘bool’
...

<--  snip  -->
Comment 1 Albert Astals Cid 2011-07-05 07:35:14 UTC
poppler is C++ code thus bool is defined there. You should be using a c++ compiler and not a c compiler as you are, fix your compiling toolchain.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.