Bug 39142

Summary:	Fix crash in call-content.c due to early unref
Product:	Telepathy	Reporter:	vincent
Component:	tp-farstream	Assignee:	Olivier Crête <olivier.crete>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description vincent 2011-07-11 07:56:21 UTC

I could get this fairly reliably when cancelling a call just after it starts.

The async result could hold the last ref to the call content, so we'd access a disposed call content after unreffing the async result.

Fixed by:
http://cgit.collabora.com/git/user/vincent/telepathy-farstream/commit/?id=f8376cac12e7025d56261c872e56c4a64610c9b4

Comment 1 Olivier Crête 2011-07-11 08:06:58 UTC

++

Comment 2 Olivier Crête 2011-07-13 12:54:20 UTC

commit f8376cac12e7025d56261c872e56c4a64610c9b4
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Mon Jul 11 17:51:49 2011 +0300

    Fix crash when ending a call early
    
    The async result might hold the last ref to self, so hold on
    unreffing it till we're done using self.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.