Bug 39186

Summary: Fix ref leak on error path
Product: Telepathy Reporter: vincent
Component: tp-farstreamAssignee: Olivier Crête <olivier.crete>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium    
Version: git master   
Hardware: Other   
OS: All   
Whiteboard: review+
i915 platform: i915 features:

Description vincent 2011-07-13 04:50:38 UTC 
The reference intended to hold self in the hash table should
be removed when not actually adding to the hash table.

Fixed here:

http://cgit.collabora.com/git/user/vincent/telepathy-farstream/commit/?h=ref&id=8d59df2d9327d1e8fb9b2d9c229071fb487d1b00
Comment 1 Nicolas Dufresne 2011-07-13 09:39:00 UTC 
Looks good.
Comment 2 Olivier Crête 2011-07-13 12:49:35 UTC 
committed:

commit ffb477d971d43cf4e704d15c4faaee6047350994
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Jul 12 19:58:04 2011 +0300

    Avoid losing a ref on error
    
    The reference intended to hold self in the hash table should
    be removed when not actually adding to the hash table.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.